This repository was archived by the owner on Jul 24, 2024. It is now read-only.
refactor(category_theory/instances): rename examples to instances#641
Closed
rwbarton wants to merge 2 commits intoleanprover-community:masterfrom
Closed
refactor(category_theory/instances): rename examples to instances#641rwbarton wants to merge 2 commits intoleanprover-community:masterfrom
examples to instances#641rwbarton wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
6 tasks
Collaborator
Author
|
I don't understand what caused |
Collaborator
rwbarton
added a commit
to leanprover-fork/mathlib-backup
that referenced
this pull request
Jan 30, 2019
PR leanprover-community#641 involved renaming a directory. The old directory was still present in the cache, and in this situation `git status` lists the directory as a whole as untracked, so the grep did not find any `.lean` files.
avigad
pushed a commit
that referenced
this pull request
Jan 30, 2019
* chore(.travis.yml): use git clean to clean out untracked files and delete more obsolete olean files PR #641 involved renaming a directory. The old directory was still present in the cache, and in this situation `git status` lists the directory as a whole as untracked, so the grep did not find any `.lean` files.
Collaborator
|
Something went wrong here. As far as I see it this is merged now. |
Collaborator
|
Yes, Reid and I found a different path which should avoid this sort of situation in the future and I took the liberty of doing the merge. Also, the maintainers elected in Amsterdam now have commit rights :) |
cipher1024
pushed a commit
that referenced
this pull request
Feb 8, 2019
* chore(.travis.yml): use git clean to clean out untracked files and delete more obsolete olean files PR #641 involved renaming a directory. The old directory was still present in the cache, and in this situation `git status` lists the directory as a whole as untracked, so the grep did not find any `.lean` files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #376, but I want to separate it because I have other PRs in the pipeline which modify these files.
For reviewers: code review check list