This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(*): removed unneeded imports#18926
Closed
[Merged by Bors] - chore(*): removed unneeded imports#18926
Conversation
eric-wieser
reviewed
May 3, 2023
eric-wieser
approved these changes
May 3, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
LGTM
bors d+
pending discussion on Zulip
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
mcdoll
reviewed
May 3, 2023
Comment on lines
7
to
9
| import analysis.inner_product_space.basic | ||
|
|
||
| import analysis.inner_product_space.basic |
Collaborator
|
Looks like you have a failure in |
Collaborator
Author
|
bors p=10 |
Remove duplicate
bors bot
pushed a commit
that referenced
this pull request
May 3, 2023
This is another run of #17568, scrubbing unnecessary imports. Like last time we only remove genuinely unneeded imports, and leave merely transitively redundant imports alone. (I *still* disagree with the objectors to removing transitively redundant imports Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Build failed: |
Collaborator
Author
|
bors merge p=10 |
bors bot
pushed a commit
that referenced
this pull request
May 4, 2023
This is another run of #17568, scrubbing unnecessary imports. Like last time we only remove genuinely unneeded imports, and leave merely transitively redundant imports alone. (I *still* disagree with the objectors to removing transitively redundant imports Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another run of #17568, scrubbing unnecessary imports.
Like last time we only remove genuinely unneeded imports, and leave merely transitively redundant imports alone.
(I still disagree with the objectors to removing transitively redundant imports --- they are of minuscule value, and make it much harder to do this sort of import cleanup.)
Unfortunately this will conflict badly with @loefflerd's #18914, sorry. :-(