Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

chore(analysis): remove lots more unnecessary imports#18914

Closed
loefflerd wants to merge 17 commits intomasterfrom
00-DL_reduce_imports2
Closed

chore(analysis): remove lots more unnecessary imports#18914
loefflerd wants to merge 17 commits intomasterfrom
00-DL_reduce_imports2

Conversation

@loefflerd
Copy link
Copy Markdown
Collaborator


Open in Gitpod

@eric-wieser
Copy link
Copy Markdown
Member

Note that in general we decided that removing transitive imports was a bad thing for maintainability.

@eric-wieser
Copy link
Copy Markdown
Member

See #17568 for some discussion

@loefflerd loefflerd marked this pull request as ready for review May 3, 2023 03:53
@loefflerd loefflerd added the awaiting-review The author would like community review of the PR label May 3, 2023
@loefflerd
Copy link
Copy Markdown
Collaborator Author

I am closing this PR because it conflicts massively with Scott's PR #18926.

@loefflerd loefflerd closed this May 3, 2023
@loefflerd loefflerd deleted the 00-DL_reduce_imports2 branch May 3, 2023 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

awaiting-review The author would like community review of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants