This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(data/set/semiring): add an idem_semiring instance#18449
Closed
eric-wieser wants to merge 6 commits intomasterfrom
Closed
[Merged by Bors] - chore(data/set/semiring): add an idem_semiring instance#18449eric-wieser wants to merge 6 commits intomasterfrom
idem_semiring instance#18449eric-wieser wants to merge 6 commits intomasterfrom
Conversation
1 task
|
This PR/issue depends on: |
319e1f8 to
8785dea
Compare
YaelDillies
approved these changes
Feb 26, 2023
Collaborator
YaelDillies
left a comment
There was a problem hiding this comment.
Very nice!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
eric-wieser
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 27, 2023
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
This typeclass is reasonably new, so some obvious instances are missing. Also adds some basic API lemmas that were missing about the casting functions `set.up` and `set_semiring.down`. forward-ported as leanprover-community/mathlib4#2518
|
Build failed: |
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
This typeclass is reasonably new, so some obvious instances are missing. Also adds some basic API lemmas that were missing about the casting functions `set.up` and `set_semiring.down`. forward-ported as leanprover-community/mathlib4#2518
|
Pull request successfully merged into master. Build succeeded: |
idem_semiring instanceidem_semiring instance
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 2, 2023
The diff being ported is leanprover-community/mathlib3port@d034837#diff-968496f13ddf1f2e9b559f374e46c52125a2ada4f449bbce0989bc8ef4965e67. This also includes a fix from leanprover-community/mathlib3#18539
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
#18539) Previously this was abusing the defeq of the types, resulting in lemmas stated in weird ways. This also fixes a type in #18449, and adds three missing lemmas about `image_hom`. Forward port of `set_semiring` will be included in leanprover-community/mathlib4#2518
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 2, 2023
The diff being ported is leanprover-community/mathlib3port@d034837#diff-968496f13ddf1f2e9b559f374e46c52125a2ada4f449bbce0989bc8ef4965e67. This also includes a fix from leanprover-community/mathlib3#18539
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This typeclass is reasonably new, so some obvious instances are missing.
Also adds some basic API lemmas that were missing about the casting functions
set.upandset_semiring.down.forward-ported as leanprover-community/mathlib4#2518