This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - refactor(set_theory/ordinal/basic): ordinal.min → infi#14707
Closed
[Merged by Bors] - refactor(set_theory/ordinal/basic): ordinal.min → infi#14707
ordinal.min → infi#14707Conversation
min → Infordinal.min → infi
|
This PR/issue depends on: |
Collaborator
Author
|
Getting a random timeout here too. |
5 tasks
4 tasks
eric-wieser
reviewed
Jul 16, 2022
Member
eric-wieser
left a comment
There was a problem hiding this comment.
Can you update the module docstring?
urkud
reviewed
Jul 22, 2022
Member
urkud
left a comment
There was a problem hiding this comment.
I have two trivial comments, otherwise LGTM.
| cInf_le ⟨⊥, λ a _, bot_le⟩ h | ||
|
|
||
| theorem cinfi_le' (f : ι → α) (i : ι) : infi f ≤ f i := | ||
| cinfi_le ⟨⊥, λ a _, bot_le⟩ _ |
Member
There was a problem hiding this comment.
We have a lemma called order_bot.bdd_below (or something very similar). Even though this lemma is trivial, it makes sense to use it here for readability.
Collaborator
Author
There was a problem hiding this comment.
This lemma could be used all throughout this section. I think that would make a good small, but separate PR.
| (rel_embedding.preimage _ _).is_well_order | ||
|
|
||
| instance is_well_order.subtype_nonempty : nonempty {r // is_well_order σ r} := | ||
| ⟨⟨well_ordering_rel, infer_instance⟩⟩ |
Collaborator
Author
There was a problem hiding this comment.
No, this instance isn't contained in an enclosing namespace. I think that's how it should be.
Member
There was a problem hiding this comment.
I mean, what is the full name of this instance?
Collaborator
Author
There was a problem hiding this comment.
is_well_order.subtype_nonempty is the full name.
bors bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
We ditch `ordinal.min` (which is really just `infi`). Apart from this, we add some missing theorems on conditionally complete lattices with a bottom element.
|
Pull request successfully merged into master. Build succeeded: |
ordinal.min → infiordinal.min → infi
bottine
pushed a commit
to bottine/mathlib
that referenced
this pull request
Jul 30, 2022
…r-community#14707) We ditch `ordinal.min` (which is really just `infi`). Apart from this, we add some missing theorems on conditionally complete lattices with a bottom element.
robertylewis
pushed a commit
that referenced
this pull request
Aug 2, 2022
We ditch `ordinal.min` (which is really just `infi`). Apart from this, we add some missing theorems on conditionally complete lattices with a bottom element.
khwilson
pushed a commit
that referenced
this pull request
Aug 2, 2022
We ditch `ordinal.min` (which is really just `infi`). Apart from this, we add some missing theorems on conditionally complete lattices with a bottom element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ditch
ordinal.min(which is really justinfi). Apart from this, we add some missing theorems on conditionally complete lattices with a bottom element.well_founded.conditionally_complete_linear_order_with_bot#14706