Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - refactor(order/conditionally_complete_lattice): tweak well_founded.conditionally_complete_linear_order_with_bot#14706

Closed
vihdzp wants to merge 7 commits intomasterfrom
lattice_api_match
Closed

[Merged by Bors] - refactor(order/conditionally_complete_lattice): tweak well_founded.conditionally_complete_linear_order_with_bot#14706
vihdzp wants to merge 7 commits intomasterfrom
lattice_api_match

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Jun 13, 2022

We change the well_founded assumption on well_founded.conditionally_complete_linear_order_bot to an equivalent but more convenient is_well_order typeclass assumption. As such, we place it in the is_well_order namespace.


Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Jun 13, 2022
@eric-wieser
Copy link
Copy Markdown
Member

eric-wieser commented Jun 13, 2022

I recall seeing a PR that did something similar if not the exact same thing, was I hallucinating?

#14568

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed awaiting-review The author would like community review of the PR awaiting-author A reviewer has asked the author a question or requested changes labels Jun 13, 2022
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jun 13, 2022
@ghost
Copy link
Copy Markdown

ghost commented Jun 13, 2022

@eric-wieser eric-wieser added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jun 13, 2022
@vihdzp vihdzp removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jun 13, 2022
@urkud
Copy link
Copy Markdown
Member

urkud commented Jun 20, 2022

Could you please update the top-level comment? It will become the commit message and it describes #14568, not this PR.

@bors
Copy link
Copy Markdown

bors bot commented Jun 20, 2022

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@vihdzp vihdzp added the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 20, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 20, 2022
@vihdzp
Copy link
Copy Markdown
Collaborator Author

vihdzp commented Jun 20, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jun 20, 2022
…onditionally_complete_linear_order_with_bot` (#14706)

We change the `well_founded` assumption on `well_founded.conditionally_complete_linear_order_bot` to an equivalent but more convenient `is_well_order` typeclass assumption. As such, we place it in the `is_well_order` namespace.
@bors
Copy link
Copy Markdown

bors bot commented Jun 20, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(order/conditionally_complete_lattice): tweak well_founded.conditionally_complete_linear_order_with_bot [Merged by Bors] - refactor(order/conditionally_complete_lattice): tweak well_founded.conditionally_complete_linear_order_with_bot Jun 20, 2022
@bors bors bot closed this Jun 20, 2022
@bors bors bot deleted the lattice_api_match branch June 20, 2022 09:15
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants