This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(linear_algebra/multilinear/finite_dimensional): generalize to finite and free#14199
Closed
eric-wieser wants to merge 6 commits intomasterfrom
Closed
[Merged by Bors] - feat(linear_algebra/multilinear/finite_dimensional): generalize to finite and free#14199eric-wieser wants to merge 6 commits intomasterfrom
eric-wieser wants to merge 6 commits intomasterfrom
Conversation
…o a new file `linear_algebra.matrix.to_lin` pulls in a lot of imports that appear to slow things down considerably in downstream files.
….finite_dimensional' into eric-wieser/multilinear_map.free
|
This PR/issue depends on: |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Oliver Nash <github@olivernash.org>
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
May 18, 2022
…nite and free (#14199) This also renames some `free` and `finite` instances which had garbage names.
alexjbest
reviewed
May 18, 2022
| instance [nontrivial R] [module.finite R M] [module.finite R N] : module.free R (M →ₗ[R] N) := | ||
| instance linear_map [module.finite R M] [module.finite R N] : module.free R (M →ₗ[R] N) := | ||
| begin | ||
| casesI subsingleton_or_nontrivial R, |
Member
There was a problem hiding this comment.
Do you know why apply_instance (and therefore nontriviality) doesn't work here?
Member
Author
There was a problem hiding this comment.
No, I was puzzled by that too.
|
Pull request successfully merged into master. Build succeeded: |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also renames some
freeandfiniteinstances which had garbage names.