Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - chore(linear_algebra/multilinear/basic): move finite-dimensionality to a new file#14198

Closed
eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser/move-multilinear_map.finite_dimensional
Closed

[Merged by Bors] - chore(linear_algebra/multilinear/basic): move finite-dimensionality to a new file#14198
eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser/move-multilinear_map.finite_dimensional

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented May 17, 2022

linear_algebra.matrix.to_lin pulls in a lot of imports that appear to slow things down considerably in downstream files.

The proof is moved without modification.


Open in Gitpod

…o a new file

`linear_algebra.matrix.to_lin` pulls in a lot of imports that appear to slow things down considerably in downstream files.
@eric-wieser eric-wieser added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels May 17, 2022
@eric-wieser eric-wieser requested a review from ocfnash May 17, 2022 12:25
@eric-wieser eric-wieser force-pushed the eric-wieser/move-multilinear_map.finite_dimensional branch from 8e9d7f6 to 21de19a Compare May 17, 2022 13:43
@ocfnash
Copy link
Copy Markdown
Collaborator

ocfnash commented May 17, 2022

LGTM

bors d+

@bors
Copy link
Copy Markdown

bors bot commented May 17, 2022

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels May 17, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label May 17, 2022
@eric-wieser
Copy link
Copy Markdown
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 17, 2022
bors bot pushed a commit that referenced this pull request May 17, 2022
…o a new file (#14198)

`linear_algebra.matrix.to_lin` pulls in a lot of imports that appear to slow things down considerably in downstream files.

The proof is moved without modification.
@bors
Copy link
Copy Markdown

bors bot commented May 17, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request May 17, 2022
…o a new file (#14198)

`linear_algebra.matrix.to_lin` pulls in a lot of imports that appear to slow things down considerably in downstream files.

The proof is moved without modification.
@bors
Copy link
Copy Markdown

bors bot commented May 17, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request May 17, 2022
…o a new file (#14198)

`linear_algebra.matrix.to_lin` pulls in a lot of imports that appear to slow things down considerably in downstream files.

The proof is moved without modification.
@bors
Copy link
Copy Markdown

bors bot commented May 17, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(linear_algebra/multilinear/basic): move finite-dimensionality to a new file [Merged by Bors] - chore(linear_algebra/multilinear/basic): move finite-dimensionality to a new file May 17, 2022
@bors bors bot closed this May 17, 2022
@bors bors bot deleted the eric-wieser/move-multilinear_map.finite_dimensional branch May 17, 2022 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants