Merged
Conversation
b4ea617 to
38a3846
Compare
Collaborator
Author
|
Now integrates #172 |
nomeata
reviewed
Aug 3, 2023
Contributor
nomeata
left a comment
There was a problem hiding this comment.
Nice! In one application of mine I would be interested in a variant of the API where I use .ofStream only once, and can then that to check containsStr multiple time. Of course I can cargo-cult the code in posOfSubstr, but maybe a convenient middle ground works well.
Collaborator
Author
|
Good idea! Do you think |
Contributor
|
Hmm, actually, looking close at the functions you provide, I think for my needs I’d be happy with what’s there. |
Collaborator
Author
|
I added a few things that you might find useful. This API would be a lot simpler if there was a coercion from |
Contributor
|
Great, thanks!
Could there be one? |
digama0
reviewed
Aug 15, 2023
digama0
reviewed
Aug 15, 2023
digama0
reviewed
Aug 15, 2023
digama0
reviewed
Aug 15, 2023
kim-em
reviewed
Aug 21, 2023
kim-em
reviewed
Aug 21, 2023
Co-authored-by: Scott Morrison <scott@tqft.net>
kim-em
reviewed
Aug 21, 2023
digama0
reviewed
Aug 21, 2023
digama0
reviewed
Aug 22, 2023
fgdorais
commented
Aug 22, 2023
1 task
fgdorais
added a commit
to fgdorais/batteries
that referenced
this pull request
Oct 19, 2023
A versatile implementation of the Knuth-Morris-Pratt matching algorithm. --------- Co-authored-by: James <jamesgallicchio@gmail.com> Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Scott Morrison <scott@tqft.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A versatile implementation of the Knuth-Morris-Pratt matching algorithm.