feat: S[ubs]tring.{posOf,contains}S[ubs]tr#172
Closed
JamesGallicchio wants to merge 3 commits intoleanprover-community:mainfrom
Closed
feat: S[ubs]tring.{posOf,contains}S[ubs]tr#172JamesGallicchio wants to merge 3 commits intoleanprover-community:mainfrom
JamesGallicchio wants to merge 3 commits intoleanprover-community:mainfrom
Conversation
fgdorais
added a commit
to fgdorais/batteries
that referenced
this pull request
Jul 7, 2023
fgdorais
added a commit
to fgdorais/batteries
that referenced
this pull request
Jul 7, 2023
Collaborator
|
#178 now incorporates this PR with worst case O(n+m) runtime on all new functions, where n = |s|, m = |pattern|. |
fgdorais
added a commit
to fgdorais/batteries
that referenced
this pull request
Aug 4, 2023
fgdorais
added a commit
to fgdorais/batteries
that referenced
this pull request
Aug 15, 2023
fgdorais
added a commit
to fgdorais/batteries
that referenced
this pull request
Aug 17, 2023
Collaborator
Collaborator
|
I think it's fine to just close. @JamesGallicchio is probably happy with the outcome of a faster implementation, and can take the credit for nerd-snipping @fgdorais into making the #178 PR. :-) Of course can be re-opened etc if I've missed something. |
Collaborator
Author
|
At first I was thinking the naive implementation should be kept around as the reference implementation against which we verify correctness, but then I decided that I do not care about the functional correctness of string matching :-) |
Member
|
the naive implementation isn't naive enough to be usable as a model for functional correctness. I would prefer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functions for finding or checking existence of strings in strings and substrings in substrings and those things in between.
Worst-case
O(nm)runtime on all new functions, wheren = |s|, m = |pattern|.