chore: adaptations for leanprover/lean4#3124#93
Merged
kim-em merged 6 commits intobump/v4.6.0from Jan 11, 2024
Merged
Conversation
This was referenced Jan 7, 2024
Closed
JLimperg
requested changes
Jan 10, 2024
Collaborator
JLimperg
left a comment
There was a problem hiding this comment.
Looks great otherwise, thanks!
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 12, 2024
These are adaptations required for Leo's implementation of simprocs from leanprover/lean4#3124. This is a PR to `bump/v4.6.0`. Before it can be merged we need to merge - [x] leanprover-community/batteries#496 - [x] leanprover-community/aesop#93 and then to update the lakefile so both dependencies point at the `bump/v4.6.0` branches. I've updated a number of Mathlib tactics to adjust to the new type signatures in the simplifier, and these changes need to be reviewed carefully. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are changes required to adapt to @leodemoura's leanprover/lean4#3124 PR introducing simprocs.
This relies on Leo's PR to Std: leanprover-community/batteries#496, and will be used in Mathlib's leanprover-community/mathlib4#9500 adaptation PR.
Note that the base of this PR is
bump/v4.6.0. We won't merge this until the original Lean PR has landed in anightly. At that point we'll need to merge this intonightly-testinghere (whether reviewed or not!), and then intobump/v4.6.0when it has been reviewed.