Conversation
|
nomeata
reviewed
Dec 29, 2023
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 30, 2023
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 30, 2023
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 31, 2023
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 31, 2023
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 31, 2023
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 2, 2024
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 2, 2024
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 2, 2024
leodemoura
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 2, 2024
See leanprover/lean4#3124 Remark: toolchain for PR 3124 is still being built. I tested this PR with my only local lean4.
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 2, 2024
This was referenced Jan 2, 2024
eric-wieser
reviewed
Jan 3, 2024
src/Init/Data/Fin/Basic.lean
Outdated
| shiftRight := Fin.shiftRight | ||
|
|
||
| instance : OfNat (Fin (no_index (n+1))) i where | ||
| instance ofNatInst : OfNat (Fin (no_index (n+1))) i where |
Contributor
There was a problem hiding this comment.
In mathlib, we have been using the convention of naming instances like this instOfNat as opposed to ofNatInst, which I believe is also consistent with the automatic naming rules. Is this departure from the convention an indication that the automatic naming rules are going to change soon?
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 3, 2024
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 06f577f. Benchmark Metric Change
===============================================================
- import Lean branches 1.9% (51.8 σ)
- import Lean instructions 1.9% (54.4 σ)
- import Lean maxrss 1.4% (82.1 σ)
- lake startup instructions 1.4% (21.8 σ)
- libleanshared.so binary size 2.1%
- reduceMatch maxrss 1.3% (76.0 σ)
- stdlib instructions 1.6% (516.1 σ)
- stdlib size bytes .olean 1.4%
- stdlib size lines C 2.4%
- tests/bench/ interpreted maxrss 1.2% (91.8 σ)
- tests/compiler sum binary sizes 2.0%
- workspaceSymbols instructions 2.2% (2525.1 σ)
- workspaceSymbols maxrss 1.4% (83.3 σ) |
Collaborator
|
Added |
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 6, 2024
kim-em
added a commit
to leanprover-community/aesop
that referenced
this pull request
Jan 7, 2024
joehendrix
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 11, 2024
See leanprover/lean4#3124 Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kim-em
added a commit
to leanprover-community/aesop
that referenced
this pull request
Jan 11, 2024
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 12, 2024
These are adaptations required for Leo's implementation of simprocs from leanprover/lean4#3124. This is a PR to `bump/v4.6.0`. Before it can be merged we need to merge - [x] leanprover-community/batteries#496 - [x] leanprover-community/aesop#93 and then to update the lakefile so both dependencies point at the `bump/v4.6.0` branches. I've updated a number of Mathlib tactics to adjust to the new type signatures in the simplifier, and these changes need to be reviewed carefully. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kim-em
added a commit
to leanprover-community/batteries
that referenced
this pull request
Feb 1, 2024
* feat: hover info for `rcases h : ...` (#486) * feat: hover info for `rcases h : ...` * fix * chore: adaptations for leanprover/lean4#3123 (#502) * chore: adaptations for leanprover/lean4#3123 * update toolchain * chore: remove unnecessary `have` (#516) After leanprover/lean4#3132 the linter will complain about this. * chore: simproc PR changes (#496) See leanprover/lean4#3124 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> * chore: adaptions for nightly-2023-01-11 (#524) * advance toolchain to nightly-2024-01-12, no updates required * chore: updates to DiscrTree for changes in nightly (#536) * doc: extend docstrings for `ext` and `ext1` (#525) Makes sure to mention that the patterns are processed using `rintro`, and makes sure `ext` mentions `ext1`. * docs(Data/List): typo (#529) * feat: Eq.rec lemma (#385) * chore: Add empty collection instance to BinomialHeap (#532) * Incremental Library Search (#421) This ports library_search from Mathlib to Std. It preserves the ability to do caching, but is designed to support a cacheless mode. The exact and apply tactics are named `std_exact?` and `std_apply?`, but will eventually be renamed. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> * fix termination_by clauses in LazyDiscrTree fix LibrarySearch * bump toolchain --------- Co-authored-by: Kyle Miller <kmill31415@gmail.com> Co-authored-by: Martin Dvořák <martin.dvorak@matfyz.cz> Co-authored-by: François G. Dorais <fgdorais@gmail.com> Co-authored-by: Joe Hendrix <joe@lean-fro.org> * feat: adaptations for leanprover/lean4#3159 (#557) * merge origin/main * chore: fixes for `simp` refactor (#571) * move to v4.6.0-rc1 * fix proofs --------- Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Leonardo de Moura <leonardo@microsoft.com> Co-authored-by: Joachim Breitner <mail@joachim-breitner.de> Co-authored-by: Kyle Miller <kmill31415@gmail.com> Co-authored-by: Martin Dvořák <martin.dvorak@matfyz.cz> Co-authored-by: François G. Dorais <fgdorais@gmail.com> Co-authored-by: Joe Hendrix <joe@lean-fro.org>
joehendrix
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Feb 5, 2024
See leanprover/lean4#3124 Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
fgdorais
added a commit
to fgdorais/batteries
that referenced
this pull request
Feb 18, 2024
) * feat: hover info for `rcases h : ...` (leanprover-community#486) * feat: hover info for `rcases h : ...` * fix * chore: adaptations for leanprover/lean4#3123 (leanprover-community#502) * chore: adaptations for leanprover/lean4#3123 * update toolchain * chore: remove unnecessary `have` (leanprover-community#516) After leanprover/lean4#3132 the linter will complain about this. * chore: simproc PR changes (leanprover-community#496) See leanprover/lean4#3124 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> * chore: adaptions for nightly-2023-01-11 (leanprover-community#524) * advance toolchain to nightly-2024-01-12, no updates required * chore: updates to DiscrTree for changes in nightly (leanprover-community#536) * doc: extend docstrings for `ext` and `ext1` (leanprover-community#525) Makes sure to mention that the patterns are processed using `rintro`, and makes sure `ext` mentions `ext1`. * docs(Data/List): typo (leanprover-community#529) * feat: Eq.rec lemma (leanprover-community#385) * chore: Add empty collection instance to BinomialHeap (leanprover-community#532) * Incremental Library Search (leanprover-community#421) This ports library_search from Mathlib to Std. It preserves the ability to do caching, but is designed to support a cacheless mode. The exact and apply tactics are named `std_exact?` and `std_apply?`, but will eventually be renamed. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> * fix termination_by clauses in LazyDiscrTree fix LibrarySearch * bump toolchain --------- Co-authored-by: Kyle Miller <kmill31415@gmail.com> Co-authored-by: Martin Dvořák <martin.dvorak@matfyz.cz> Co-authored-by: François G. Dorais <fgdorais@gmail.com> Co-authored-by: Joe Hendrix <joe@lean-fro.org> * feat: adaptations for leanprover/lean4#3159 (leanprover-community#557) * merge origin/main * chore: fixes for `simp` refactor (leanprover-community#571) * move to v4.6.0-rc1 * fix proofs --------- Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Leonardo de Moura <leonardo@microsoft.com> Co-authored-by: Joachim Breitner <mail@joachim-breitner.de> Co-authored-by: Kyle Miller <kmill31415@gmail.com> Co-authored-by: Martin Dvořák <martin.dvorak@matfyz.cz> Co-authored-by: François G. Dorais <fgdorais@gmail.com> Co-authored-by: Joe Hendrix <joe@lean-fro.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #3123 and #3120
Downstream changes required: