Skip to content

Fix spacing in grammar#56

Merged
JLimperg merged 1 commit intomasterfrom
space
Jun 1, 2023
Merged

Fix spacing in grammar#56
JLimperg merged 1 commit intomasterfrom
space

Conversation

@digama0
Copy link
Copy Markdown
Member

@digama0 digama0 commented May 31, 2023

Adds spaces to affect the pretty printing of the aesop tactic.

@digama0 digama0 requested a review from JLimperg May 31, 2023 02:46
return goal

elab &"aesop_destruct_products" : tactic =>
elab "aesop_destruct_products" : tactic =>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary to put & in front of the initial atom in a category with leading_ident_behavior := symbol or leading_ident_behavior := both, and tactic and attr are both of that form.

@JLimperg
Copy link
Copy Markdown
Collaborator

JLimperg commented Jun 1, 2023

Thank you very much! I thought the possibility to omit & was special-cased for the tactic category, which I didn't like and therefore didn't use. But if it's (now?) tied to leading_ident_behavior, I can accept it.

@JLimperg JLimperg merged commit ca73109 into master Jun 1, 2023
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 2, 2023
This fixes a bunch of spacing bugs in tactics. Mathlib counterpart of:

* Lean: leanprover/lean4#2240
* Std: leanprover-community/batteries#149
* Aesop: leanprover-community/aesop#56
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 2, 2023
This fixes a bunch of spacing bugs in tactics. Mathlib counterpart of:

* Lean: leanprover/lean4#2240
* Std: leanprover-community/batteries#149
* Aesop: leanprover-community/aesop#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants