fix: spacing and indentation fixes#2240
Merged
leodemoura merged 1 commit intoleanprover:masterfrom May 29, 2023
Merged
Conversation
151830d to
88b403c
Compare
This was referenced May 31, 2023
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 2, 2023
This fixes a bunch of spacing bugs in tactics. Mathlib counterpart of: * Lean: leanprover/lean4#2240 * Std: leanprover-community/batteries#149 * Aesop: leanprover-community/aesop#56
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 2, 2023
This fixes a bunch of spacing bugs in tactics. Mathlib counterpart of: * Lean: leanprover/lean4#2240 * Std: leanprover-community/batteries#149 * Aesop: leanprover-community/aesop#56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a number of spacing and indentation issues across the lean grammar. These were mainly noticed by mathport, although a lot of them can be derived just by looking at the code.
One common mistake that I fell prey to in earlier reviews of this code is that it is not safe to assume that
identandtermlists are always automatically space separated. This is because if you print an inaccessible name it is shown asx✝, where the✝is not an identifier character and hence counts as an identifier separator. In thetermcategory there are more examples, like·.