Skip to content

fix: local syntax should create private definitions#9915

Merged
zwarich merged 2 commits intoleanprover:masterfrom
Kha:push-mszkszvxwolz
Aug 19, 2025
Merged

fix: local syntax should create private definitions#9915
zwarich merged 2 commits intoleanprover:masterfrom
Kha:push-mszkszvxwolz

Conversation

@Kha
Copy link
Copy Markdown
Member

@Kha Kha commented Aug 14, 2025

This PR adjusts the elaboration of syntax and derived commands such that they create private definitions when local and thus behave as expected under the module system

@Kha Kha added awaiting-mathlib We should not merge this until we have a successful Mathlib build changelog-language Language features and metaprograms labels Aug 14, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 14, 2025
@leanprover-bot
Copy link
Copy Markdown
Collaborator

leanprover-bot commented Aug 14, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-08-12 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-08-14 10:48:25)
  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-08-14 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-08-14 15:53:31)
  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 04f9baf4d388978cca71d4e41a937c1d68c37287 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-08-18 20:48:13)

ghost pushed a commit to leanprover-community/batteries that referenced this pull request Aug 14, 2025
ghost pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Aug 14, 2025
@ghost ghost added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Aug 14, 2025
@ghost
Copy link
Copy Markdown

ghost commented Aug 14, 2025

  • 💥 Mathlib branch lean-pr-testing-9915 build failed against this PR. (2025-08-14 10:52:51) View Log
  • ✅ Mathlib branch lean-pr-testing-9915 has successfully built against this PR. (2025-08-18 12:38:07) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 04f9baf4d388978cca71d4e41a937c1d68c37287 --onto fe90da5a8ddfc2c31331e50c5d189f3f0b12c784. You can force Mathlib CI using the force-mathlib-ci label. (2025-08-18 20:48:11)

@Kha Kha force-pushed the push-mszkszvxwolz branch from b6530d5 to 5de9b9a Compare August 14, 2025 14:57
@ghost
Copy link
Copy Markdown

ghost commented Aug 14, 2025

@Kha Kha force-pushed the push-mszkszvxwolz branch from 5de9b9a to 7fb7bd5 Compare August 14, 2025 15:01
@Kha Kha enabled auto-merge August 14, 2025 15:36
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Aug 14, 2025
ghost pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Aug 14, 2025
@ghost
Copy link
Copy Markdown

ghost commented Aug 14, 2025

@ghost
Copy link
Copy Markdown

ghost commented Aug 15, 2025

@ghost
Copy link
Copy Markdown

ghost commented Aug 17, 2025

ghost pushed a commit to leanprover-community/batteries that referenced this pull request Aug 17, 2025
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Aug 17, 2025
ghost pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Aug 17, 2025
@ghost
Copy link
Copy Markdown

ghost commented Aug 17, 2025

@ghost
Copy link
Copy Markdown

ghost commented Aug 18, 2025

@ghost ghost added builds-mathlib CI has verified that Mathlib builds against this PR and removed awaiting-mathlib We should not merge this until we have a successful Mathlib build breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Aug 18, 2025
@ghost
Copy link
Copy Markdown

ghost commented Aug 18, 2025

@Kha Kha added this pull request to the merge queue Aug 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 18, 2025
@Kha Kha force-pushed the push-mszkszvxwolz branch from 9314726 to 1ef0dab Compare August 18, 2025 11:03
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Aug 18, 2025
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Aug 19, 2025
ghost pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Aug 19, 2025
@ghost ghost removed the builds-mathlib CI has verified that Mathlib builds against this PR label Aug 19, 2025
@ghost
Copy link
Copy Markdown

ghost commented Aug 19, 2025

@ghost ghost added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Aug 19, 2025
@Kha Kha force-pushed the push-mszkszvxwolz branch from f5b7fd2 to e135672 Compare August 19, 2025 09:24
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Aug 19, 2025
ghost pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Aug 19, 2025
@ghost
Copy link
Copy Markdown

ghost commented Aug 19, 2025

@Kha Kha force-pushed the push-mszkszvxwolz branch from e135672 to 3a44027 Compare August 19, 2025 16:15
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Aug 19, 2025
ghost pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Aug 19, 2025
@ghost ghost added builds-mathlib CI has verified that Mathlib builds against this PR and removed awaiting-mathlib We should not merge this until we have a successful Mathlib build breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Aug 19, 2025
@ghost
Copy link
Copy Markdown

ghost commented Aug 19, 2025

@Kha Kha force-pushed the push-mszkszvxwolz branch from 3a44027 to d6d8535 Compare August 19, 2025 20:41
@Kha Kha added the merge-ci Enable merge queue CI checks for PR. In particular, produce artifacts for all major platforms. label Aug 19, 2025
@Kha Kha force-pushed the push-mszkszvxwolz branch from d6d8535 to 7f7c0a8 Compare August 19, 2025 21:00
@zwarich zwarich merged commit 48365b6 into leanprover:master Aug 19, 2025
15 checks passed
@Kha Kha deleted the push-mszkszvxwolz branch August 20, 2025 07:35
kim-em added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Aug 24, 2025
* chore: bump to nightly-2025-08-07

* lake update aesop

* lake update aesop

* deprecations

* chore: bump to nightly-2025-08-08

* Update lean-toolchain for testing leanprover/lean4#9800

* Update lean-toolchain for leanprover/lean4#9800

* Update lean-toolchain for leanprover/lean4#9800

* Update lean-toolchain for leanprover/lean4#9800

* addressing some cases of mathlib4#380

* fix tests

* Update lean-toolchain for leanprover/lean4#9800

* Update lean-toolchain for leanprover/lean4#9800

* chore: bump to nightly-2025-08-10

* fix (all?) `protected` regressions

* Update lean-toolchain for leanprover/lean4#9800

* fix

* adaptation note?

* noncomputable

* revert grind proof

* remove upstreamed

* fixes

* feat: better statement of flip_map_app

* sad adaptation note

* update adaptation note

* fix merge

* chore: bump to nightly-2025-08-11

* chore: adaptations for nightly-2025-08-11

* chore: adaptations for nightly-2025-08-11

* fixes

* fix

* fix toolchain?

* Update lean-toolchain for testing leanprover/lean4#9729

* use legacy lemma for now

* revert bad changes

* upstream LE/LT (Subtype p) instances

* chore(Cache): use FRO cache (v2) (#30)

* chore(Cache): enable FRO cache

* feat: only print "packing" when actually packing

* feat: always prefix with repo in FRO cache

* fix

* chore: bump to nightly-2025-08-12

* chore: trigger rebuild to test cache

* chore: use `cache put!` in CI to debug

* shake --update

* chore: adaptations for nightly-2025-08-12

* empty

* chore: bump to nightly-2025-08-13

* Revert "chore: use `cache put!` in CI to debug"

This reverts commit 7c6202b.

* redundant grind warnings

* revert leanprover-community#28272: add back grind proofs

* fix test

* chore: adaptations for nightly-2025-08-13

* fixes

* restore test

* chore: bump to nightly-2025-08-14

* adaptation note about grind regression

* Update lean-toolchain for testing leanprover/lean4#9915

* fix tests

* fix

* update test output

* feat: workflow for reporting `grind` regressions

This PR contains a (untested!) workflow that is supposed to build Mathlib with a few tactic analysis flags. It reports the results of these build steps to Zulip for the FRO (and in particular Kim).

* fix

* chore: bump to nightly-2025-08-16

* bump proofwidgets

* bump proofwidgets

* Update lean-toolchain for testing leanprover/lean4#9942

* fix: namespace linter should not care about private names

* chore: bump to nightly-2025-08-17

* chore: adaptations for nightly-2025-08-17

* Update lean-toolchain for leanprover/lean4#9942

* Update lean-toolchain for leanprover/lean4#9915

* Update lean-toolchain for leanprover/lean4#9942

* make `filter_upwards` more robust to side goals

* Update lean-toolchain for leanprover/lean4#9674

* simpler change to filter_upwards

* fix

* fix test

* chore: bump to nightly-2025-08-18

* Update lean-toolchain for leanprover/lean4#9915

* Apply suggestions from code review

* Use JS to generate uuid instead of uuidgen which appears not to be installed

* GH Problem Matcher wrapper doesn't like multiline arguments; wrap multiple steps instead.

* Hmm, maybe uuidgen exists and it was gh-problem-matcher that was the issue?

* Can we just `apt install` dependencies?

* Apparently Linux exposes uuids from the kernel. Nifty!

* Then we don't need to install uuidgen

* Try also implementing a docgen step for nightly testing

* Cut off the output after 9k bytes, otherwise Zulip complains

* Fixes

* chore: bump to nightly-2025-08-19

* Update lean-toolchain for leanprover/lean4#9915

* Filter out the build progress lines.

* Switch `doc-gen4` version to "main", otherwise it complains there is no nightly-testing release.

* Update lean-toolchain for leanprover/lean4#9915

* lake update

* cleanup imports

* Fix `git remote` complaining that `nightly-testing` already exists.

* Fix error message.

* Update lean-toolchain for leanprover/lean4#9915

* fix tests

* shake --fix

* fix says

* .

* says

* chore: `curl --retry-all-errors` in `cache get`

* remove says

* chore: bump to nightly-2025-08-20

* Drop more noise from the grind report.

* lake update

* fix

* fix tests

* manual shake

* chore: adaptations for nightly-2025-08-20

* satisfy actionlint

* shellcheck

---------

Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
Co-authored-by: Kim Morrison <kim@tqft.net>
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
Co-authored-by: mathlib4-bot <github-mathlib4-bot@leanprover.zulipchat.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Paul Reichert <6992158+datokrat@users.noreply.github.com>
Co-authored-by: Mac Malone <tydeu@hatpress.net>
Co-authored-by: Mac Malone <mac@lean-fro.org>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
Co-authored-by: Kim Morrison <477956+kim-em@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
kim-em added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Aug 24, 2025
* lake update aesop

* lake update aesop

* deprecations

* chore: bump to nightly-2025-08-08

* Update lean-toolchain for testing leanprover/lean4#9800

* Update lean-toolchain for leanprover/lean4#9800

* Update lean-toolchain for leanprover/lean4#9800

* Update lean-toolchain for leanprover/lean4#9800

* addressing some cases of mathlib4#380

* fix tests

* Update lean-toolchain for leanprover/lean4#9800

* Update lean-toolchain for leanprover/lean4#9800

* chore: bump to nightly-2025-08-10

* fix (all?) `protected` regressions

* Update lean-toolchain for leanprover/lean4#9800

* fix

* adaptation note?

* noncomputable

* revert grind proof

* remove upstreamed

* fixes

* feat: better statement of flip_map_app

* sad adaptation note

* update adaptation note

* fix merge

* chore: bump to nightly-2025-08-11

* chore: adaptations for nightly-2025-08-11

* chore: adaptations for nightly-2025-08-11

* fixes

* fix

* fix toolchain?

* Update lean-toolchain for testing leanprover/lean4#9729

* use legacy lemma for now

* revert bad changes

* upstream LE/LT (Subtype p) instances

* chore(Cache): use FRO cache (v2) (#30)

* chore(Cache): enable FRO cache

* feat: only print "packing" when actually packing

* feat: always prefix with repo in FRO cache

* fix

* chore: bump to nightly-2025-08-12

* chore: trigger rebuild to test cache

* chore: use `cache put!` in CI to debug

* shake --update

* chore: adaptations for nightly-2025-08-12

* empty

* chore: bump to nightly-2025-08-13

* Revert "chore: use `cache put!` in CI to debug"

This reverts commit 7c6202b.

* redundant grind warnings

* revert leanprover-community#28272: add back grind proofs

* fix test

* chore: adaptations for nightly-2025-08-13

* fixes

* restore test

* chore: bump to nightly-2025-08-14

* adaptation note about grind regression

* Update lean-toolchain for testing leanprover/lean4#9915

* fix tests

* fix

* update test output

* feat: workflow for reporting `grind` regressions

This PR contains a (untested!) workflow that is supposed to build Mathlib with a few tactic analysis flags. It reports the results of these build steps to Zulip for the FRO (and in particular Kim).

* fix

* chore: bump to nightly-2025-08-16

* bump proofwidgets

* bump proofwidgets

* Update lean-toolchain for testing leanprover/lean4#9942

* fix: namespace linter should not care about private names

* chore: bump to nightly-2025-08-17

* chore: adaptations for nightly-2025-08-17

* Update lean-toolchain for leanprover/lean4#9942

* Update lean-toolchain for leanprover/lean4#9915

* Update lean-toolchain for leanprover/lean4#9942

* make `filter_upwards` more robust to side goals

* Update lean-toolchain for leanprover/lean4#9674

* simpler change to filter_upwards

* fix

* fix test

* chore: bump to nightly-2025-08-18

* Update lean-toolchain for leanprover/lean4#9915

* Apply suggestions from code review

* Use JS to generate uuid instead of uuidgen which appears not to be installed

* GH Problem Matcher wrapper doesn't like multiline arguments; wrap multiple steps instead.

* Hmm, maybe uuidgen exists and it was gh-problem-matcher that was the issue?

* Can we just `apt install` dependencies?

* Apparently Linux exposes uuids from the kernel. Nifty!

* Then we don't need to install uuidgen

* Try also implementing a docgen step for nightly testing

* Cut off the output after 9k bytes, otherwise Zulip complains

* Fixes

* chore: bump to nightly-2025-08-19

* Update lean-toolchain for leanprover/lean4#9915

* Filter out the build progress lines.

* Switch `doc-gen4` version to "main", otherwise it complains there is no nightly-testing release.

* Update lean-toolchain for leanprover/lean4#9915

* lake update

* cleanup imports

* Fix `git remote` complaining that `nightly-testing` already exists.

* Fix error message.

* Update lean-toolchain for leanprover/lean4#9915

* fix tests

* shake --fix

* fix says

* .

* says

* chore: `curl --retry-all-errors` in `cache get`

* remove says

* chore: bump to nightly-2025-08-20

* Drop more noise from the grind report.

* lake update

* fix

* fix tests

* manual shake

* chore: adaptations for nightly-2025-08-20

* chore: bump to nightly-2025-08-21

* chore: adaptations for nightly-2025-08-21

* satisfy actionlint

* shellcheck

---------

Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
Co-authored-by: Kim Morrison <kim@tqft.net>
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
Co-authored-by: mathlib4-bot <github-mathlib4-bot@leanprover.zulipchat.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Paul Reichert <6992158+datokrat@users.noreply.github.com>
Co-authored-by: Mac Malone <tydeu@hatpress.net>
Co-authored-by: Mac Malone <mac@lean-fro.org>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
Co-authored-by: Kim Morrison <477956+kim-em@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
kim-em added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Aug 26, 2025
* chore: adaptations for nightly-2025-08-11

* fixes

* fix

* fix toolchain?

* Update lean-toolchain for testing leanprover/lean4#9729

* use legacy lemma for now

* revert bad changes

* upstream LE/LT (Subtype p) instances

* chore(Cache): use FRO cache (v2) (#30)

* chore(Cache): enable FRO cache

* feat: only print "packing" when actually packing

* feat: always prefix with repo in FRO cache

* fix

* chore: bump to nightly-2025-08-12

* chore: trigger rebuild to test cache

* chore: use `cache put!` in CI to debug

* shake --update

* chore: adaptations for nightly-2025-08-12

* empty

* chore: bump to nightly-2025-08-13

* Revert "chore: use `cache put!` in CI to debug"

This reverts commit 7c6202b.

* redundant grind warnings

* revert leanprover-community#28272: add back grind proofs

* fix test

* chore: adaptations for nightly-2025-08-13

* fixes

* restore test

* chore: bump to nightly-2025-08-14

* adaptation note about grind regression

* Update lean-toolchain for testing leanprover/lean4#9915

* fix tests

* fix

* update test output

* feat: workflow for reporting `grind` regressions

This PR contains a (untested!) workflow that is supposed to build Mathlib with a few tactic analysis flags. It reports the results of these build steps to Zulip for the FRO (and in particular Kim).

* fix

* chore: bump to nightly-2025-08-16

* bump proofwidgets

* bump proofwidgets

* Update lean-toolchain for testing leanprover/lean4#9942

* fix: namespace linter should not care about private names

* chore: bump to nightly-2025-08-17

* chore: adaptations for nightly-2025-08-17

* Update lean-toolchain for leanprover/lean4#9942

* Update lean-toolchain for leanprover/lean4#9915

* Update lean-toolchain for leanprover/lean4#9942

* make `filter_upwards` more robust to side goals

* Update lean-toolchain for leanprover/lean4#9674

* simpler change to filter_upwards

* fix

* fix test

* chore: bump to nightly-2025-08-18

* Update lean-toolchain for leanprover/lean4#9915

* Apply suggestions from code review

* Use JS to generate uuid instead of uuidgen which appears not to be installed

* GH Problem Matcher wrapper doesn't like multiline arguments; wrap multiple steps instead.

* Hmm, maybe uuidgen exists and it was gh-problem-matcher that was the issue?

* Can we just `apt install` dependencies?

* Apparently Linux exposes uuids from the kernel. Nifty!

* Then we don't need to install uuidgen

* Try also implementing a docgen step for nightly testing

* Cut off the output after 9k bytes, otherwise Zulip complains

* Fixes

* chore: bump to nightly-2025-08-19

* Update lean-toolchain for leanprover/lean4#9915

* Filter out the build progress lines.

* Switch `doc-gen4` version to "main", otherwise it complains there is no nightly-testing release.

* Update lean-toolchain for leanprover/lean4#9915

* lake update

* cleanup imports

* Fix `git remote` complaining that `nightly-testing` already exists.

* Fix error message.

* Update lean-toolchain for leanprover/lean4#9915

* fix tests

* shake --fix

* fix says

* .

* says

* chore: `curl --retry-all-errors` in `cache get`

* remove says

* chore: bump to nightly-2025-08-20

* Drop more noise from the grind report.

* lake update

* fix

* fix tests

* manual shake

* chore: adaptations for nightly-2025-08-20

* chore: bump to nightly-2025-08-21

* chore: adaptations for nightly-2025-08-21

* feat: create `nightly-testing-daily` and `nightly-testing-green` branches

These two branches track the `nightly-testing-YYYY-MM-DD` tags and the latest successfully built `nightly-testing` commit, respectively. These can then be used for other CI actions such as tests that run every night.

* chore: bump to nightly-2025-08-22

* Switch the workflows over to nightly-testing-green branch

* chore: bump to nightly-2025-08-23

* chore: bump to nightly-2025-08-24

* satisfy actionlint

* shellcheck

* fix

* fix

* fix for nightly-2025-08-24 (#42)

* fix

* please rebuild yourself

* maybe that works?

* fix

* rat fixes

* fixes

* fixes

* fix

* .'

* fix

* not there yet

* comment out Int.shiftLeft_add'

* Revert "comment out Int.shiftLeft_add'"

This reverts commit b33c9d7.

* fix proof

* change Polynomial.eval signature

* workaround for initialization order issue

* fixes

* fix

* fix message

* Actually import the linters we want to run.

* chore: bump to nightly-2025-08-25

* remove upstream `Rat` material

* fix `sigmaProdDistrib`

* more `Rat` fixes

* `Rat.inv_def'` -> `Rat.inv_def`

* fixes

* comment out `rw_search` tests

* small test fix

* shake --fix

* Revert

---------

Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
Co-authored-by: Paul Reichert <6992158+datokrat@users.noreply.github.com>
Co-authored-by: Mac Malone <tydeu@hatpress.net>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Mac Malone <mac@lean-fro.org>
Co-authored-by: mathlib4-bot <github-mathlib4-bot@leanprover.zulipchat.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Rob23oba <152706811+Rob23oba@users.noreply.github.com>
Co-authored-by: Rob23oba <robin.arnez@web.de>
kim-em added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Sep 2, 2025
* chore: bump to nightly-2025-08-14

* adaptation note about grind regression

* Update lean-toolchain for testing leanprover/lean4#9915

* fix tests

* fix

* Update lean-toolchain for testing leanprover/lean4#9918

* Update tests

* update test output

* feat: workflow for reporting `grind` regressions

This PR contains a (untested!) workflow that is supposed to build Mathlib with a few tactic analysis flags. It reports the results of these build steps to Zulip for the FRO (and in particular Kim).

* fix

* chore: bump to nightly-2025-08-16

* bump proofwidgets

* bump proofwidgets

* Update lean-toolchain for testing leanprover/lean4#9942

* fix: namespace linter should not care about private names

* chore: bump to nightly-2025-08-17

* chore: adaptations for nightly-2025-08-17

* Update lean-toolchain for leanprover/lean4#9942

* Update lean-toolchain for leanprover/lean4#9915

* Update lean-toolchain for leanprover/lean4#9942

* make `filter_upwards` more robust to side goals

* Update lean-toolchain for leanprover/lean4#9674

* simpler change to filter_upwards

* fix

* fix test

* chore: bump to nightly-2025-08-18

* Update lean-toolchain for leanprover/lean4#9915

* Apply suggestions from code review

* Use JS to generate uuid instead of uuidgen which appears not to be installed

* GH Problem Matcher wrapper doesn't like multiline arguments; wrap multiple steps instead.

* Hmm, maybe uuidgen exists and it was gh-problem-matcher that was the issue?

* Can we just `apt install` dependencies?

* Apparently Linux exposes uuids from the kernel. Nifty!

* Then we don't need to install uuidgen

* Try also implementing a docgen step for nightly testing

* Cut off the output after 9k bytes, otherwise Zulip complains

* Fixes

* chore: bump to nightly-2025-08-19

* Update lean-toolchain for leanprover/lean4#9915

* Filter out the build progress lines.

* Switch `doc-gen4` version to "main", otherwise it complains there is no nightly-testing release.

* Update lean-toolchain for leanprover/lean4#9915

* lake update

* cleanup imports

* Fix `git remote` complaining that `nightly-testing` already exists.

* Fix error message.

* Update lean-toolchain for leanprover/lean4#9915

* fix tests

* shake --fix

* fix says

* .

* says

* chore: `curl --retry-all-errors` in `cache get`

* remove says

* chore: bump to nightly-2025-08-20

* Drop more noise from the grind report.

* lake update

* fix

* fix tests

* manual shake

* chore: adaptations for nightly-2025-08-20

* chore: bump to nightly-2025-08-21

* chore: adaptations for nightly-2025-08-21

* feat: create `nightly-testing-daily` and `nightly-testing-green` branches

These two branches track the `nightly-testing-YYYY-MM-DD` tags and the latest successfully built `nightly-testing` commit, respectively. These can then be used for other CI actions such as tests that run every night.

* chore: bump to nightly-2025-08-22

* Switch the workflows over to nightly-testing-green branch

* chore: bump to nightly-2025-08-23

* chore: bump to nightly-2025-08-24

* satisfy actionlint

* shellcheck

* fix

* fix

* fix for nightly-2025-08-24 (#42)

* fix

* please rebuild yourself

* maybe that works?

* fix

* rat fixes

* fixes

* fixes

* fix

* .'

* fix

* not there yet

* comment out Int.shiftLeft_add'

* Revert "comment out Int.shiftLeft_add'"

This reverts commit b33c9d7.

* fix proof

* change Polynomial.eval signature

* workaround for initialization order issue

* fixes

* fix

* fix message

* Actually import the linters we want to run.

* chore: bump to nightly-2025-08-25

* remove upstream `Rat` material

* fix `sigmaProdDistrib`

* more `Rat` fixes

* `Rat.inv_def'` -> `Rat.inv_def`

* fixes

* comment out `rw_search` tests

* small test fix

* shake --fix

* Revert

* Move docgen reports to a different Zulip stream

* chore: adaptations for nightly-2025-08-25

* Fix `git checkout` not restoring the right version of the lakefile

* Fix name of mathlib dependency

* chore: bump to nightly-2025-08-26

* addSuggestionCore

* lake update

* chore: adapt `to_additive` to lean4#9966 (#45)

* lake update

* chore: Lean.Grind order structures replaced with Std versions

* ibid

* fixes

* comment out UInt theorems

* Bump batteries

* chore: adapt `hint` tactic to lean4#9966 (#46)

* chore: adapt Hint to lean4#9966

* space after emoji

* rework how `hint` finds try this suggestions

* fix tests

* docstring and formatting

* indentation

* chore: bump to nightly-2025-08-27

* TMToPartrec relies on a default value

oops

* lake update

* fix try this output in tests

* fix uint

* chore: adaptations for nightly-2025-08-27

* fix

* wrong toolchain??

* lake update

* fix merge

* fix merge

* revert sqrt changes

* ugh

* fix from nightly-testing

* fix test

* note about test

* .

---------

Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
Co-authored-by: Joachim Breitner <mail@joachim-breitner.de>
Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
Co-authored-by: mathlib4-bot <github-mathlib4-bot@leanprover.zulipchat.com>
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Mac Malone <mac@lean-fro.org>
Co-authored-by: Rob23oba <152706811+Rob23oba@users.noreply.github.com>
Co-authored-by: Rob23oba <robin.arnez@web.de>
Co-authored-by: thorimur <68410468+thorimur@users.noreply.github.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kim-em added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Sep 2, 2025
* fix: namespace linter should not care about private names

* chore: bump to nightly-2025-08-17

* chore: adaptations for nightly-2025-08-17

* Update lean-toolchain for leanprover/lean4#9942

* Update lean-toolchain for leanprover/lean4#9915

* Update lean-toolchain for leanprover/lean4#9942

* make `filter_upwards` more robust to side goals

* Update lean-toolchain for leanprover/lean4#9674

* simpler change to filter_upwards

* fix

* fix test

* chore: bump to nightly-2025-08-18

* Update lean-toolchain for leanprover/lean4#9915

* Apply suggestions from code review

* Use JS to generate uuid instead of uuidgen which appears not to be installed

* GH Problem Matcher wrapper doesn't like multiline arguments; wrap multiple steps instead.

* Hmm, maybe uuidgen exists and it was gh-problem-matcher that was the issue?

* Can we just `apt install` dependencies?

* Apparently Linux exposes uuids from the kernel. Nifty!

* Then we don't need to install uuidgen

* Try also implementing a docgen step for nightly testing

* Cut off the output after 9k bytes, otherwise Zulip complains

* Fixes

* chore: bump to nightly-2025-08-19

* Update lean-toolchain for leanprover/lean4#9915

* Filter out the build progress lines.

* Switch `doc-gen4` version to "main", otherwise it complains there is no nightly-testing release.

* Update lean-toolchain for leanprover/lean4#9915

* lake update

* cleanup imports

* Fix `git remote` complaining that `nightly-testing` already exists.

* Fix error message.

* Update lean-toolchain for leanprover/lean4#9915

* fix tests

* shake --fix

* fix says

* .

* says

* chore: `curl --retry-all-errors` in `cache get`

* remove says

* chore: bump to nightly-2025-08-20

* Drop more noise from the grind report.

* lake update

* fix

* fix tests

* manual shake

* chore: adaptations for nightly-2025-08-20

* chore: bump to nightly-2025-08-21

* chore: adaptations for nightly-2025-08-21

* feat: create `nightly-testing-daily` and `nightly-testing-green` branches

These two branches track the `nightly-testing-YYYY-MM-DD` tags and the latest successfully built `nightly-testing` commit, respectively. These can then be used for other CI actions such as tests that run every night.

* chore: bump to nightly-2025-08-22

* Switch the workflows over to nightly-testing-green branch

* chore: bump to nightly-2025-08-23

* chore: bump to nightly-2025-08-24

* satisfy actionlint

* shellcheck

* fix

* fix

* fix for nightly-2025-08-24 (#42)

* fix

* please rebuild yourself

* maybe that works?

* fix

* rat fixes

* fixes

* fixes

* fix

* .'

* fix

* not there yet

* comment out Int.shiftLeft_add'

* Revert "comment out Int.shiftLeft_add'"

This reverts commit b33c9d7.

* fix proof

* change Polynomial.eval signature

* workaround for initialization order issue

* fixes

* fix

* fix message

* Actually import the linters we want to run.

* chore: bump to nightly-2025-08-25

* remove upstream `Rat` material

* fix `sigmaProdDistrib`

* more `Rat` fixes

* `Rat.inv_def'` -> `Rat.inv_def`

* fixes

* comment out `rw_search` tests

* small test fix

* shake --fix

* Revert

* Move docgen reports to a different Zulip stream

* chore: adaptations for nightly-2025-08-25

* Fix `git checkout` not restoring the right version of the lakefile

* Fix name of mathlib dependency

* chore: bump to nightly-2025-08-26

* addSuggestionCore

* lake update

* chore: adapt `to_additive` to lean4#9966 (#45)

* lake update

* chore: Lean.Grind order structures replaced with Std versions

* ibid

* fixes

* comment out UInt theorems

* Bump batteries

* chore: adapt `hint` tactic to lean4#9966 (#46)

* chore: adapt Hint to lean4#9966

* space after emoji

* rework how `hint` finds try this suggestions

* fix tests

* docstring and formatting

* indentation

* chore: bump to nightly-2025-08-27

* TMToPartrec relies on a default value

oops

* lake update

* fix try this output in tests

* fix uint

* chore: adaptations for nightly-2025-08-27

* toolchain got reverted??

* merge lean-pr-testing-9918

* fix

* wrong toolchain??

* lake update

* field_simp Nat Int multiplication issue

* fixes to hint file after field_simp refactor

* fix refs + add adaptation note

* actually fix reassoc

* fix warnings

* oops

* chore: bump to nightly-2025-08-29

* lake exe shake --update

* restore Mathlib.Data.Seq.Basic from upstream

* chore: bump to nightly-2025-08-30

* lake update batteries

* fix

* fix merge

* fix merge

* revert sqrt changes

* ugh

* fix from nightly-testing

* fix merge

* fix test

* note about test

* .

* fix

* mk_all

---------

Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
Co-authored-by: mathlib4-bot <github-mathlib4-bot@leanprover.zulipchat.com>
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
Co-authored-by: Mac Malone <mac@lean-fro.org>
Co-authored-by: Rob23oba <152706811+Rob23oba@users.noreply.github.com>
Co-authored-by: Rob23oba <robin.arnez@web.de>
Co-authored-by: thorimur <68410468+thorimur@users.noreply.github.com>
Co-authored-by: Joachim Breitner <mail@joachim-breitner.de>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
kim-em added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Sep 3, 2025
* fix

* fix test

* chore: bump to nightly-2025-08-18

* Update lean-toolchain for leanprover/lean4#9915

* Apply suggestions from code review

* Use JS to generate uuid instead of uuidgen which appears not to be installed

* GH Problem Matcher wrapper doesn't like multiline arguments; wrap multiple steps instead.

* Hmm, maybe uuidgen exists and it was gh-problem-matcher that was the issue?

* Can we just `apt install` dependencies?

* Apparently Linux exposes uuids from the kernel. Nifty!

* Then we don't need to install uuidgen

* Try also implementing a docgen step for nightly testing

* Cut off the output after 9k bytes, otherwise Zulip complains

* Fixes

* chore: bump to nightly-2025-08-19

* Update lean-toolchain for leanprover/lean4#9915

* Filter out the build progress lines.

* Switch `doc-gen4` version to "main", otherwise it complains there is no nightly-testing release.

* Update lean-toolchain for leanprover/lean4#9915

* lake update

* cleanup imports

* Fix `git remote` complaining that `nightly-testing` already exists.

* Fix error message.

* Update lean-toolchain for leanprover/lean4#9915

* fix tests

* shake --fix

* fix says

* .

* says

* chore: `curl --retry-all-errors` in `cache get`

* remove says

* chore: bump to nightly-2025-08-20

* Drop more noise from the grind report.

* lake update

* fix

* fix tests

* manual shake

* chore: adaptations for nightly-2025-08-20

* chore: bump to nightly-2025-08-21

* chore: adaptations for nightly-2025-08-21

* feat: create `nightly-testing-daily` and `nightly-testing-green` branches

These two branches track the `nightly-testing-YYYY-MM-DD` tags and the latest successfully built `nightly-testing` commit, respectively. These can then be used for other CI actions such as tests that run every night.

* chore: bump to nightly-2025-08-22

* Switch the workflows over to nightly-testing-green branch

* chore: bump to nightly-2025-08-23

* chore: bump to nightly-2025-08-24

* satisfy actionlint

* shellcheck

* fix

* fix

* fix for nightly-2025-08-24 (#42)

* fix

* please rebuild yourself

* maybe that works?

* fix

* rat fixes

* fixes

* fixes

* fix

* .'

* fix

* not there yet

* comment out Int.shiftLeft_add'

* Revert "comment out Int.shiftLeft_add'"

This reverts commit b33c9d7.

* fix proof

* change Polynomial.eval signature

* workaround for initialization order issue

* fixes

* fix

* fix message

* Actually import the linters we want to run.

* chore: bump to nightly-2025-08-25

* remove upstream `Rat` material

* fix `sigmaProdDistrib`

* more `Rat` fixes

* `Rat.inv_def'` -> `Rat.inv_def`

* fixes

* comment out `rw_search` tests

* small test fix

* shake --fix

* Revert

* Move docgen reports to a different Zulip stream

* chore: adaptations for nightly-2025-08-25

* Fix `git checkout` not restoring the right version of the lakefile

* Fix name of mathlib dependency

* chore: bump to nightly-2025-08-26

* addSuggestionCore

* lake update

* chore: adapt `to_additive` to lean4#9966 (#45)

* lake update

* chore: Lean.Grind order structures replaced with Std versions

* ibid

* fixes

* comment out UInt theorems

* Bump batteries

* chore: adapt `hint` tactic to lean4#9966 (#46)

* chore: adapt Hint to lean4#9966

* space after emoji

* rework how `hint` finds try this suggestions

* fix tests

* docstring and formatting

* indentation

* chore: bump to nightly-2025-08-27

* TMToPartrec relies on a default value

oops

* lake update

* fix try this output in tests

* fix uint

* chore: adaptations for nightly-2025-08-27

* toolchain got reverted??

* merge lean-pr-testing-9918

* fix

* wrong toolchain??

* lake update

* field_simp Nat Int multiplication issue

* fixes to hint file after field_simp refactor

* fix refs + add adaptation note

* actually fix reassoc

* fix warnings

* oops

* chore: bump to nightly-2025-08-29

* lake exe shake --update

* restore Mathlib.Data.Seq.Basic from upstream

* chore: bump to nightly-2025-08-30

* Merge master into nightly-testing

* chore: bump to nightly-2025-08-31

* lake update batteries

* fix

* bump toolchain

* chore: adaptations for nightly-2025-08-31

* fix merge

* fix merge

* revert sqrt changes

* ugh

* fix from nightly-testing

* fix merge

* fix test

* note about test

* .

* fix

---------

Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: mathlib4-bot <github-mathlib4-bot@leanprover.zulipchat.com>
Co-authored-by: Kim Morrison <477956+kim-em@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
Co-authored-by: Kim Morrison <kim@tqft.net>
Co-authored-by: Mac Malone <mac@lean-fro.org>
Co-authored-by: Rob23oba <152706811+Rob23oba@users.noreply.github.com>
Co-authored-by: Rob23oba <robin.arnez@web.de>
Co-authored-by: thorimur <68410468+thorimur@users.noreply.github.com>
Co-authored-by: Joachim Breitner <mail@joachim-breitner.de>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms merge-ci Enable merge queue CI checks for PR. In particular, produce artifacts for all major platforms. toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants