Conversation
2fe37c6 to
357828a
Compare
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 16, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 16, 2025
|
Mathlib CI status (docs):
|
Rob23oba
reviewed
May 16, 2025
Rob23oba
reviewed
May 16, 2025
357828a to
0e081fe
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 24, 2025
This PR adds further `@[grind]` annotations for `Option`, as follow-up to the recent additions to the `Option` API in #8379 and #8298. **However**, I am concurrently investigating adding `attribute [grind cases] Option`, which will result in many (most?) of the annotations for `Option` being removed again. In any case, I'm going to merge this first, as if that is viable I would like to test that most/all the lemmas now marked with `@[grind]` are still provable by `grind`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing
Optionlemmas.Also:
bindMfromMonadtoPuresimpnormal form of both<|>andOption.orElsetoOption.or