Skip to content

feat: Option lemmas and cleanup#8298

Merged
TwoFX merged 4 commits intomasterfrom
markus/option-lemmas-4
May 13, 2025
Merged

feat: Option lemmas and cleanup#8298
TwoFX merged 4 commits intomasterfrom
markus/option-lemmas-4

Conversation

@TwoFX
Copy link
Copy Markdown
Member

@TwoFX TwoFX commented May 12, 2025

This PR adds various Option lemmas and defines Option.filterM for applicative functors.

@TwoFX TwoFX requested a review from kim-em as a code owner May 12, 2025 14:23
@TwoFX TwoFX added the changelog-library Library label May 12, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 12, 2025
ghost pushed a commit to leanprover-community/batteries that referenced this pull request May 12, 2025
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 12, 2025
@ghost ghost added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label May 12, 2025
@ghost
Copy link
Copy Markdown

ghost commented May 12, 2025

Mathlib CI status (docs):

ghost pushed a commit to leanprover-community/batteries that referenced this pull request May 13, 2025
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 13, 2025
ghost pushed a commit to leanprover-community/batteries that referenced this pull request May 13, 2025
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 13, 2025
@ghost ghost added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels May 13, 2025
@TwoFX TwoFX enabled auto-merge May 13, 2025 08:41
@TwoFX TwoFX added this pull request to the merge queue May 13, 2025
Merged via the queue into master with commit 8eec1e4 May 13, 2025
23 checks passed
github-merge-queue bot pushed a commit that referenced this pull request May 24, 2025
This PR adds further `@[grind]` annotations for `Option`, as follow-up
to the recent additions to the `Option` API in #8379 and #8298.

**However**, I am concurrently investigating adding `attribute [grind
cases] Option`, which will result in many (most?) of the annotations for
`Option` being removed again. In any case, I'm going to merge this
first, as if that is viable I would like to test that most/all the
lemmas now marked with `@[grind]` are still provable by `grind`.
@TwoFX TwoFX deleted the markus/option-lemmas-4 branch August 4, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant