Skip to content

feat: Nat, Fin and BitVec theorems required for unsigned integers#7522

Merged
TwoFX merged 1 commit intomasterfrom
markus/nat-theory-for-7484
Mar 18, 2025
Merged

feat: Nat, Fin and BitVec theorems required for unsigned integers#7522
TwoFX merged 1 commit intomasterfrom
markus/nat-theory-for-7484

Conversation

@TwoFX
Copy link
Copy Markdown
Member

@TwoFX TwoFX commented Mar 17, 2025

This PR splits off the required theory about Nat, Fin and BitVec from #7484.

@TwoFX TwoFX added the changelog-library Library label Mar 17, 2025
tobiasgrosser
tobiasgrosser approved these changes Mar 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tobiasgrosser tobiasgrosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TwoFX. This looks great. My approval is not needed, but here some comments that would help me to better understand our naming conventions.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 17, 2025 13:10 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 17, 2025
@ghost
Copy link
Copy Markdown

ghost commented Mar 17, 2025 •
edited by ghost
Loading

Mathlib CI status (docs):

  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2025-03-16 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. You can force Mathlib CI using the force-mathlib-ci label. (2025-03-17 13:26:01)
    Forcing Mathlib CI because the force-mathlib-ci label is present, despite problem: - ❗ Batteries CI can not be attempted yet, as the nightly-testing-2025-03-16 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2025-03-17 14:49:30)
  • 💥 Mathlib branch lean-pr-testing-7522 build failed against this PR. (2025-03-17 14:53:18) View Log
    Forcing Mathlib CI because the force-mathlib-ci label is present, despite problem: - ❗ Batteries CI can not be attempted yet, as the nightly-testing-2025-03-17 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2025-03-17 15:29:24)
  • 💥 Mathlib branch lean-pr-testing-7522 build failed against this PR. (2025-03-17 15:36:27) View Log
  • ✅ Mathlib branch lean-pr-testing-7522 has successfully built against this PR. (2025-03-18 08:00:09) View Log

tobiasgrosser
tobiasgrosser reviewed Mar 17, 2025
View reviewed changes
@TwoFX
Copy link
Copy Markdown
Member Author

TwoFX commented Mar 17, 2025

Thanks for the review! I should have paid closer attention to the conventions in the BitVec files.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 17, 2025 14:36 Inactive
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Mar 17, 2025
Update lean-toolchain for testing leanprover/lean4#7522
4e55d4b
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Mar 17, 2025
Update lean-toolchain for testing leanprover/lean4#7522
7c2279c
@ghost ghost added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Mar 17, 2025
@TwoFX TwoFX force-pushed the markus/nat-theory-for-7484 branch from 8ef51fb to 670d936 Compare March 17, 2025 15:00
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 17, 2025 15:13 Inactive
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Mar 17, 2025
Trigger CI for leanprover/lean4#7522
279106a
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Mar 17, 2025
Trigger CI for leanprover/lean4#7522
6849308
@ghost ghost added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Mar 18, 2025
@TwoFX TwoFX marked this pull request as ready for review March 18, 2025 08:34
@TwoFX TwoFX requested a review from kim-em as a code owner March 18, 2025 08:34
@TwoFX TwoFX enabled auto-merge March 18, 2025 08:34
@TwoFX TwoFX added this pull request to the merge queue Mar 18, 2025
Merged via the queue into master with commit 6a202f5 Mar 18, 2025
22 checks passed
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 31, 2025
@kim-em @Kha
@TwoFX @jcommelin @nomeata @kmill @digama0
chore: adaptations for nightly-2025-03-28 (#23400)
c13efa9 
* fix

* fix again

* chore: bump to nightly-2025-03-15

* fix

* harden script

* chore: bump to nightly-2025-03-16

* Update lean-toolchain for testing leanprover/lean4#7516

* lake update

* fixes for leanprover/lean4#7516

* fixes for leanprover/lean4#7516

* partial test fixes

* fix stacks

* "fix" eqns test

* Remove neg instance, there is one upstream now

* chore: bump to nightly-2025-03-17

* lake update

* lake update

* lint

* Update lean-toolchain for testing leanprover/lean4#7522

* Update lean-toolchain for testing leanprover/lean4#5182

* Bump batteries for leanprover/lean4#5182

* simp works

* Fewer unseal

* Trigger CI for leanprover/lean4#5182

* max heartbeats

* update test

* Update lean-toolchain for testing leanprover/lean4#7519

* Update lean-toolchain for testing leanprover/lean4#7302

* Fix

* fixes

* Trigger CI for leanprover/lean4#5182

* chore: bump to nightly-2025-03-18

* Less rfl abuse

* fix `compile_inductive%` regression

* Trigger CI for leanprover/lean4#5182

* Trigger CI for leanprover/lean4#5182

* Trigger CI for leanprover/lean4#5182

* Adapt

* process deprecations

* Update lean-toolchain for testing leanprover/lean4#7558

* Adapt

* deprecations

* chore: bump to nightly-2025-03-19

* chore: fixes for leanprover/lean4#7519

* Update lean-toolchain for testing leanprover/lean4#7544

* lake update

* fixes for leanprover/lean4#7544

* fixes for leanprover/lean4#7544

* fixes for leanprover/lean4#7544

* fixes for leanprover/lean4#7544

* Trigger CI for leanprover/lean4#7544

* .

* cleaning up

* chore: bump to nightly-2025-03-20

* update

* deprecation/note about upstreamed version

* fix

* Update lean-toolchain for testing leanprover/lean4#7614

* chore: bump to nightly-2025-03-21

* Adapt back

* fix test output

* chore: bump to nightly-2025-03-22

* Merge master into nightly-testing

* chore: adaptations for nightly-2025-03-22

* fix

* Merge master into nightly-testing

* protected

* chore: bump to nightly-2025-03-24

* update batteries and aesop

* fixes for count_cons_of_ne

* fix fix to Sym.inhabitedSym' (need `default`, not the `a` that happens to be in context)

* bump heartbeats in MathlibTest/observe

* fix, deprecated

* fix merge

* Update lean-toolchain for testing leanprover/lean4#7672

* Trigger CI for leanprover/lean4#7672

* update batteries

* fixes for leanprover/lean4#7672

* Trigger CI for leanprover/lean4#7672

* Trigger CI for leanprover/lean4#7672

* Trigger CI for leanprover/lean4#7672

* Trigger CI for leanprover/lean4#7672

* Trigger CI for leanprover/lean4#7672

* update batteries

* fixes

* chore: bump to nightly-2025-03-25

* Trigger CI for leanprover/lean4#7672

* Trigger CI for leanprover/lean4#7672

* update batteries

* Trigger CI for leanprover/lean4#7672

* one fix

* fixes

* maxheartbeats

* fixes for leanprover/lean4#7672

* fixes for leanprover/lean4#7672

* fixes for leanprover/lean4#7672

* fixes for leanprover/lean4#7672

* cleanups

* .

* chore: bump to nightly-2025-03-26

* update aesop

* Update lean-toolchain for testing leanprover/lean4#7690

* Trigger CI for leanprover/lean4#7690

* Trigger CI for leanprover/lean4#7690

* maxHeartbeats

* max heartbeats

* invalidate cache

* another heartbeats

* bump batteries

* deprecation

* Update lean-toolchain for testing leanprover/lean4#7692

* Delete

* chore: bump to nightly-2025-03-27

* update batteries

* bump batteries

* many more maxHeartbeats

* chore: bump leantar v0.1.15

* invalidate cache

* cache flush, take 2

* feat(Cache): root hash generation counter

* 1-line fix

* chore: bump to nightly-2025-03-28

* update deps

* remove upstreamed

* remove all adaptation notes, hooray

* merge lean-pr-testing-7692

* fixes from Kevin's review

---------

Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
Co-authored-by: Markus Himmel <markus@lean-fro.org>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Joachim Breitner <mail@joachim-breitner.de>
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@TwoFX TwoFX deleted the markus/nat-theory-for-7484 branch August 4, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

1 more reviewer

@tobiasgrosser tobiasgrosser tobiasgrosser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library force-mathlib-ci toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TwoFX @tobiasgrosser