Skip to content

chore: remove the old Lean.Data.HashMap implementation#7519

Merged
kim-em merged 8 commits intomasterfrom
rm_lean_hashmap
Mar 21, 2025
Merged

chore: remove the old Lean.Data.HashMap implementation#7519
kim-em merged 8 commits intomasterfrom
rm_lean_hashmap

Conversation

@kim-em
Copy link
Copy Markdown
Collaborator

@kim-em kim-em commented Mar 17, 2025

This PR removes Lean.Data.HashMap and HashSet. These have been deprecated for 6 months, replaced by Std.Data.HashMap and HashSet.

@kim-em kim-em requested review from leodemoura and tydeu as code owners March 17, 2025 04:34
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 17, 2025
@ghost
Copy link
Copy Markdown

ghost commented Mar 17, 2025 •
edited by ghost
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d32a7b250ad20477d55034488d89a050fbf70af5 --onto d5f01f2db1efd18034421ae2f40120d1c608f3c0. You can force Mathlib CI using the force-mathlib-ci label. (2025-03-17 06:38:43)
  • 💥 Mathlib branch lean-pr-testing-7519 build failed against this PR. (2025-03-18 03:18:22) View Log
  • ✅ Mathlib branch lean-pr-testing-7519 has successfully built against this PR. (2025-03-20 03:01:51) View Log

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 17, 2025 08:08 Inactive
TwoFX
TwoFX reviewed Mar 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to remove src/Lean/Data/HashMap.lean?

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 18, 2025 03:01 Inactive
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Mar 18, 2025
Update lean-toolchain for testing leanprover/lean4#7519
9d6e491
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Mar 18, 2025
Update lean-toolchain for testing leanprover/lean4#7519
882b2a0
@ghost ghost added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Mar 18, 2025
@kim-em kim-em mentioned this pull request Mar 20, 2025
Merged
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 20, 2025
@kim-em
chore: fixes for leanprover/lean4#7519
5bcf0e9
@kim-em kim-em removed the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Mar 20, 2025
@ghost ghost added the builds-mathlib CI has verified that Mathlib builds against this PR label Mar 20, 2025
@kim-em kim-em added this pull request to the merge queue Mar 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2025
@kim-em
Copy link
Copy Markdown
Collaborator Author

kim-em commented Mar 20, 2025

merge-ci

@kim-em kim-em added this pull request to the merge queue Mar 20, 2025
Merged via the queue into master with commit 74ffa1e Mar 21, 2025
25 checks passed
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 31, 2025
@kim-em @Kha
@TwoFX @jcommelin @nomeata @kmill @digama0
chore: adaptations for nightly-2025-03-28 (#23400)
c13efa9 
* fix

* fix again

* chore: bump to nightly-2025-03-15

* fix

* harden script

* chore: bump to nightly-2025-03-16

* Update lean-toolchain for testing leanprover/lean4#7516

* lake update

* fixes for leanprover/lean4#7516

* fixes for leanprover/lean4#7516

* partial test fixes

* fix stacks

* "fix" eqns test

* Remove neg instance, there is one upstream now

* chore: bump to nightly-2025-03-17

* lake update

* lake update

* lint

* Update lean-toolchain for testing leanprover/lean4#7522

* Update lean-toolchain for testing leanprover/lean4#5182

* Bump batteries for leanprover/lean4#5182

* simp works

* Fewer unseal

* Trigger CI for leanprover/lean4#5182

* max heartbeats

* update test

* Update lean-toolchain for testing leanprover/lean4#7519

* Update lean-toolchain for testing leanprover/lean4#7302

* Fix

* fixes

* Trigger CI for leanprover/lean4#5182

* chore: bump to nightly-2025-03-18

* Less rfl abuse

* fix `compile_inductive%` regression

* Trigger CI for leanprover/lean4#5182

* Trigger CI for leanprover/lean4#5182

* Trigger CI for leanprover/lean4#5182

* Adapt

* process deprecations

* Update lean-toolchain for testing leanprover/lean4#7558

* Adapt

* deprecations

* chore: bump to nightly-2025-03-19

* chore: fixes for leanprover/lean4#7519

* Update lean-toolchain for testing leanprover/lean4#7544

* lake update

* fixes for leanprover/lean4#7544

* fixes for leanprover/lean4#7544

* fixes for leanprover/lean4#7544

* fixes for leanprover/lean4#7544

* Trigger CI for leanprover/lean4#7544

* .

* cleaning up

* chore: bump to nightly-2025-03-20

* update

* deprecation/note about upstreamed version

* fix

* Update lean-toolchain for testing leanprover/lean4#7614

* chore: bump to nightly-2025-03-21

* Adapt back

* fix test output

* chore: bump to nightly-2025-03-22

* Merge master into nightly-testing

* chore: adaptations for nightly-2025-03-22

* fix

* Merge master into nightly-testing

* protected

* chore: bump to nightly-2025-03-24

* update batteries and aesop

* fixes for count_cons_of_ne

* fix fix to Sym.inhabitedSym' (need `default`, not the `a` that happens to be in context)

* bump heartbeats in MathlibTest/observe

* fix, deprecated

* fix merge

* Update lean-toolchain for testing leanprover/lean4#7672

* Trigger CI for leanprover/lean4#7672

* update batteries

* fixes for leanprover/lean4#7672

* Trigger CI for leanprover/lean4#7672

* Trigger CI for leanprover/lean4#7672

* Trigger CI for leanprover/lean4#7672

* Trigger CI for leanprover/lean4#7672

* Trigger CI for leanprover/lean4#7672

* update batteries

* fixes

* chore: bump to nightly-2025-03-25

* Trigger CI for leanprover/lean4#7672

* Trigger CI for leanprover/lean4#7672

* update batteries

* Trigger CI for leanprover/lean4#7672

* one fix

* fixes

* maxheartbeats

* fixes for leanprover/lean4#7672

* fixes for leanprover/lean4#7672

* fixes for leanprover/lean4#7672

* fixes for leanprover/lean4#7672

* cleanups

* .

* chore: bump to nightly-2025-03-26

* update aesop

* Update lean-toolchain for testing leanprover/lean4#7690

* Trigger CI for leanprover/lean4#7690

* Trigger CI for leanprover/lean4#7690

* maxHeartbeats

* max heartbeats

* invalidate cache

* another heartbeats

* bump batteries

* deprecation

* Update lean-toolchain for testing leanprover/lean4#7692

* Delete

* chore: bump to nightly-2025-03-27

* update batteries

* bump batteries

* many more maxHeartbeats

* chore: bump leantar v0.1.15

* invalidate cache

* cache flush, take 2

* feat(Cache): root hash generation counter

* 1-line fix

* chore: bump to nightly-2025-03-28

* update deps

* remove upstreamed

* remove all adaptation notes, hooray

* merge lean-pr-testing-7692

* fixes from Kevin's review

---------

Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
Co-authored-by: Markus Himmel <markus@lean-fro.org>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Joachim Breitner <mail@joachim-breitner.de>
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwoFX TwoFX TwoFX left review comments

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kim-em @TwoFX @ashandoak