fix: load references asynchronously#3552
Merged
mhuisi merged 2 commits intoleanprover:masterfrom Mar 1, 2024
Merged
Conversation
Kha
approved these changes
Mar 1, 2024
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 1, 2024
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 1, 2024
|
Mathlib CI status (docs):
|
mhuisi
added a commit
to mhuisi/lean4
that referenced
this pull request
Mar 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
Benchmark to catch future regressions as the one fixed in #3552.
kim-em
pushed a commit
that referenced
this pull request
Mar 4, 2024
In v4.6.0, there was a significant regression in initial server startup performance because the .ilean files got bigger in #3082 and we load the information stored in all .ilean files synchronously when the server starts up. This PR makes this loading asynchronous. The trade-off is that requests that are issued right after the initial server start when the references are not fully loaded yet may yield incomplete results. Benchmark for this in a separate PR soon after this one. --------- Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v4.6.0, there was a significant regression in initial server startup performance because the .ilean files got bigger in #3082 and we load the information stored in all .ilean files synchronously when the server starts up.
This PR makes this loading asynchronous. The trade-off is that requests that are issued right after the initial server start when the references are not fully loaded yet may yield incomplete results.
Benchmark for this in a separate PR soon after this one.