CCS: Process as map rather than CBOR encoded map#281
Merged
geonnave merged 4 commits intolake-rs:mainfrom May 23, 2024
Merged
Conversation
Member
Author
|
I've tested this between Lakers devices. No plugtest happend on this solution yet, but I think it's enough of an improvement to merge it once reviewed -- I don't know when I next get around to doing more interop tests with others. |
geonnave
reviewed
May 23, 2024
geonnave
reviewed
May 23, 2024
Collaborator
|
Looks good to me! Leave a 👍 here when you think it is ready to merge. |
Member
Author
|
👍 You may or may not want to merge #279 first, not sure whether it will be auto-closed when merging this. |
Merged
Closed
chrysn
added a commit
to chrysn/aiocoap
that referenced
this pull request
Jun 22, 2024
They are not used this way, and lakers-python 0.3.1 still does not have lake-rs/lakers#281 applied, but nonetheless provides more variation for testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #273, this hopefully brings the credentials by value in line with the specification.