Skip to content

Fix credential-by-value#279

Merged
geonnave merged 1 commit intolake-rs:mainfrom
geonnave:fix-cred-by-value
May 23, 2024
Merged

Fix credential-by-value#279
geonnave merged 1 commit intolake-rs:mainfrom
geonnave:fix-cred-by-value

Conversation

@geonnave
Copy link
Copy Markdown
Collaborator

Fixes #273.

Copy link
Copy Markdown
Member

@chrysn chrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test yet. Comments inline.

@chrysn
Copy link
Copy Markdown
Member

chrysn commented May 22, 2024

It appears that something is wrong with the commits. Could it be that your changes were committed --amend to the latest merge commit?

@chrysn chrysn force-pushed the fix-cred-by-value branch from 0a91345 to c1181f9 Compare May 22, 2024 11:37
@chrysn
Copy link
Copy Markdown
Member

chrysn commented May 22, 2024

I've taken the liberty to force-push a version that has an actual commit in there.

@chrysn
Copy link
Copy Markdown
Member

chrysn commented May 22, 2024

I have now tested this and it works on self-interop. Let's see if we can even squeeze one more interop test into this hackathon.

@geonnave geonnave force-pushed the fix-cred-by-value branch from c1181f9 to a5ce6f2 Compare May 22, 2024 15:40
@geonnave geonnave force-pushed the fix-cred-by-value branch from a5ce6f2 to fd5c257 Compare May 22, 2024 15:40
@geonnave
Copy link
Copy Markdown
Collaborator Author

I believe all is addressed.

@chrysn
Copy link
Copy Markdown
Member

chrysn commented May 22, 2024

We're not there yet: from interop, we did {/kccs/14: <<{...}>>} while Marco (and the IANA registry) say it is {/kccs/14: {...}}

@chrysn chrysn mentioned this pull request May 23, 2024
@geonnave
Copy link
Copy Markdown
Collaborator Author

Final part of the fix provided in PR #281.

@geonnave geonnave merged commit 76ae15b into lake-rs:main May 23, 2024
@geonnave geonnave added the type:bug/fix Something isn't working / a PR fixes something that is not working label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug/fix Something isn't working / a PR fixes something that is not working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Are we doing credential-by-value wrong?

2 participants