Merged
Conversation
This makes the APIs clearer and paves the way for adding support for longer C_x. This alters the Python API to consistently use bytes for connection identifiers. Once lake-rs#258 is done, it will automatically allow the Python API to support more values. Contributes-To: lake-rs#258
This is an API change, and allows responders to build full OSCORE contexts through knowledge of the initiator's chosen C_I. Closes: lake-rs#259
Member
Author
|
All green, squashed and ready for review! |
Collaborator
|
Good! Thanks. |
chrysn
added a commit
to chrysn-pull-requests/ariel-os
that referenced
this pull request
May 13, 2024
The updated Lakers exposes C_I to responders[261], so we don't need hard-coded knowledge of the peer's chosen C_I any more. [261]: lake-rs/lakers#261
chrysn
added a commit
to chrysn-pull-requests/ariel-os
that referenced
this pull request
May 14, 2024
The updated Lakers exposes C_I to responders[261], so we don't need hard-coded knowledge of the peer's chosen C_I any more. [261]: lake-rs/lakers#261
chrysn
added a commit
to chrysn-pull-requests/ariel-os
that referenced
this pull request
May 15, 2024
The updated Lakers exposes C_I to responders[261], so we don't need hard-coded knowledge of the peer's chosen C_I any more. [261]: lake-rs/lakers#261
chrysn
added a commit
to chrysn-pull-requests/ariel-os
that referenced
this pull request
May 17, 2024
The updated Lakers exposes C_I to responders[261], so we don't need hard-coded knowledge of the peer's chosen C_I any more. [261]: lake-rs/lakers#261
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends-On: #260 (therefore, just check the top commit)
Closes: #258
On the Python side, this follows the convention established in #260 to represent ConnId as bytes instead of an integer (so we won't need an API change there once ConnId can get larger)