C_x: Represent using own ConnectionIdentifier newtype#260
C_x: Represent using own ConnectionIdentifier newtype#260geonnave merged 1 commit intolake-rs:mainfrom
Conversation
|
Thanks, so far looks good. |
|
Thanks. Big rename coming up with the squash. Yes, I have a plan, and I'm adding a |
(rename to ConnId as per lake-rs#260 (comment))
|
Great!
That concerns me a bit, tracking at #262. |
More precisely, things do work, but for the same reasons I advocated against having the C API the last time it was removed I don't want so sink too much time there, so I am fixing the examples, but not the API; consequently, unlike the Python API, once we do support longer identifiers, the C API can't use them. |
This makes the APIs clearer and paves the way for adding support for longer C_x. This alters the Python API to consistently use bytes for connection identifiers. Once lake-rs#258 is done, it will automatically allow the Python API to support more values. Contributes-To: lake-rs#258
|
All green, squashed and ready for final review. |
|
Looks good, thanks. I can take on updating the C API later -- there's an important C-based project in the lab which need lakers working on it. |
This makes the APIs clearer and paves the way for adding support for longer C_x.
Contributes-To: #258
Marked as a draft while waiting for CI checks (I only did
cargo testwhich usually misses some)