🐛 pkg/crd: support validation on type alias to basic types#1078
Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom Oct 25, 2024
Merged
🐛 pkg/crd: support validation on type alias to basic types#1078k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
Conversation
Contributor
|
Hi @mtardy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Without the type Alias being its own type (Go 1.22 see gotypesalias), in localNamedToSchema, the link is missing. [ Upstream port of cilium/controller-tools@d944debcff34 ("Support type aliasing to basic types") ] Previously, validation schema generation was skipped on a type alias: type A = B Whereas, a new type was fine: type A B This commit implements support for generating validation schemas for type aliases to basic types, i.e. string, int, etc. Co-authored-by: Chris Tarazi <tarazichris@gmail.com> Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
This patch will be needed when upgrading to Go 1.23 as type alias now generate a proper type (instead of directly being the basic type they alias to), see https://pkg.go.dev/go/types#Alias for more info. This just reproduces the old behavior by retrieving the underlying type from the alias. If needed, we could treat alias more gracefully to make the type ref link now that we have all the type information. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
fc92564 to
e443da3
Compare
Member
Author
|
/cc @sbueringer Since you commented here #1071 (comment). |
Member
|
/ok-to-test |
Member
|
Thank you very much!! /lgtm |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 8cde2ff060f2cedfdd25b0ed7bcbb387098d501d |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtardy, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sayboras
pushed a commit
to cilium/cilium
that referenced
this pull request
Mar 19, 2025
This closes off GHSA-qxp5-gwg8-xv66 Just a note that go 1.23 type alias breaks controller-tools code generation, so gotypesalias=0 is set to keep the same behavior in go 1.22. Relates: kubernetes-sigs/controller-tools#1078 Relates: #35406 Signed-off-by: Feroz Salam <feroz.salam@isovalent.com> Signed-off-by: Tam Mach <tam.mach@cilium.io>
ferozsalam
added a commit
to cilium/cilium
that referenced
this pull request
Mar 20, 2025
This closes off GHSA-qxp5-gwg8-xv66 Just a note that go 1.23 type alias breaks controller-tools code generation, so gotypesalias=0 is set to keep the same behavior in go 1.22. Relates: kubernetes-sigs/controller-tools#1078 Relates: #35406 Signed-off-by: Feroz Salam <feroz.salam@isovalent.com> Signed-off-by: Tam Mach <tam.mach@cilium.io>
ferozsalam
added a commit
to cilium/cilium
that referenced
this pull request
Mar 20, 2025
This resolves GHSA-qxp5-gwg8-xv66 Just a note that go 1.23 type alias breaks controller-tools code generation, so gotypesalias=0 is set to keep the same behavior in go 1.22. Relates: kubernetes-sigs/controller-tools#1078 Relates: #35406 Signed-off-by: Feroz Salam <feroz.salam@isovalent.com> Co-authored-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Mar 20, 2025
This closes off GHSA-qxp5-gwg8-xv66 Just a note that go 1.23 type alias breaks controller-tools code generation, so gotypesalias=0 is set to keep the same behavior in go 1.22. Relates: kubernetes-sigs/controller-tools#1078 Relates: #35406 Signed-off-by: Feroz Salam <feroz.salam@isovalent.com> Signed-off-by: Tam Mach <tam.mach@cilium.io>
ferozsalam
added a commit
to cilium/cilium
that referenced
this pull request
Mar 21, 2025
This resolves GHSA-qxp5-gwg8-xv66 Just a note that go 1.23 type alias breaks controller-tools code generation, so gotypesalias=0 is set to keep the same behavior in go 1.22. Relates: kubernetes-sigs/controller-tools#1078 Relates: #35406 Signed-off-by: Feroz Salam <feroz.salam@isovalent.com> Co-authored-by: Tam Mach <tam.mach@cilium.io>
julianwiedmann
pushed a commit
to cilium/cilium
that referenced
this pull request
Mar 21, 2025
This resolves GHSA-qxp5-gwg8-xv66 Just a note that go 1.23 type alias breaks controller-tools code generation, so gotypesalias=0 is set to keep the same behavior in go 1.22. Relates: kubernetes-sigs/controller-tools#1078 Relates: #35406 Signed-off-by: Feroz Salam <feroz.salam@isovalent.com> Co-authored-by: Tam Mach <tam.mach@cilium.io>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1071
Without the type Alias being its own type (Go 1.22 see gotypesalias), in localNamedToSchema, the link is missing.
[ Upstream port of d944deb ("Support type aliasing to basic types") ]
Previously, validation schema generation was skipped on a type alias:
Whereas, a new type was fine:
This commit implements support for generating validation schemas for type aliases to basic types, i.e. string, int, etc.