Support type aliasing to basic types

christarazi · christarazi · commit d944debcff34 · 2020-08-13T20:34:07.000-07:00
Previously, validation schema generation was skipped on a type alias:

```
type A = B
```

Whereas, a new type was fine:

```
type A B
```

This commit implements support for generating validation schemas for
type aliases to basic types, i.e. string, int, etc.

Signed-off-by: Chris Tarazi &lt;tarazichris@gmail.com&gt;
diff --git a/pkg/crd/schema.go b/pkg/crd/schema.go
@@ -208,9 +208,21 @@ func localNamedToSchema(ctx *schemaContext, ident *ast.Ident) *apiext.JSONSchema
 		if err != nil {
 			ctx.pkg.AddError(loader.ErrFromNode(err, ident))
 		}
+
+		// Check for type aliasing. If the type is not an alias, then handle it
+		// as a basic type.
+		if basicInfo.Name() == ident.Name {
+			return &apiext.JSONSchemaProps{
+				Type:   typ,
+				Format: fmt,
+			}
+		}
+
+		// Type alias to a basic type.
+		ctx.requestSchema("", ident.Name)
+		link := TypeRefLink("", ident.Name)
 		return &apiext.JSONSchemaProps{
-			Type:   typ,
-			Format: fmt,
+			Ref: &link,
 		}
 	}
 	// NB(directxman12): if there are dot imports, this might be an external reference,
