WIP: use vendor dir#113
Closed
pohly wants to merge 10 commits into
Closed
Conversation
Add new variables for 1.16 and remove 1.13
This is the latest release. Updating is useful to ensure that we have all of the latest fixes and enhancements.
Some operations are sensitive to the version of Go that is used. In the past, formatting of source differed depending on the version. Right now it is the content of the vendor directory which changes when switch back and forth between 1.12 and 1.13. We don't want to impose a certain workflow on developers, like forcing all invocations of Go to run inside a container. If developers want that, they can set up their development environment accordingly. But we should warn about this aspect to raise awareness. "make" invocations which involve Go now compare against the projects Go version (specified in travis.yml) once at the beginning. This is only a warning because we don't know which future version will be compatible with the project. Vendor directory handling gets updated, too: verification is now a separate script (became too complex for make) and there is a corresponding "update-vendor.sh". In contrast to verification, updating vendor is not integrated into make and thus itself invokes the go version check.
Go version 1.13, helper scripts
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This avoids dependencies on the Go module cache or the upstream code hosting.
Contributor
Author
|
Replaced by #115 |
xing-yang
added a commit
to xing-yang/csi-driver-host-path
that referenced
this pull request
Nov 19, 2020
c6a88c6 Merge pull request kubernetes-csi#113 from xing-yang/install_snapshot_controller 45ec4c6 Fix the install of snapshot CRDs and controller git-subtree-dir: release-tools git-subtree-split: c6a88c6
Merged
fengzixu
pushed a commit
to fengzixu/csi-driver-host-path
that referenced
this pull request
Dec 31, 2020
…_controller Fix the install of snapshot CRDs and controller
pohly
added a commit
to pohly/csi-driver-host-path
that referenced
this pull request
Mar 15, 2021
00bc64a9 remove travis.yml, Go 1.16 REVERT: 7bc70e5 Merge pull request kubernetes-csi#129 from pohly/squash-documentation REVERT: e0b02e7 README.md: document usage of --squash REVERT: 316cb95 Merge pull request kubernetes-csi#132 from yiyang5055/bugfix/boilerplate REVERT: 26e2ab1 fix: default boilerplate path REVERT: 1add8c1 Merge pull request kubernetes-csi#133 from pohly/kubernetes-1.20-tag REVERT: 3e811d6 prow.sh: fix "on-master" prow jobs REVERT: 1d60e77 Merge pull request kubernetes-csi#131 from pohly/kubernetes-1.20-tag REVERT: 9f10459 prow.sh: support building Kubernetes for a specific version REVERT: fe1f284 Merge pull request kubernetes-csi#121 from kvaps/namespace-check REVERT: 8fdf0f7 Merge pull request kubernetes-csi#128 from fengzixu/master REVERT: 1c94220 fix: fix a bug of csi-sanity REVERT: a4c41e6 Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate REVERT: ece0f50 check namespace for snapshot-controller REVERT: dbd8967 verify-boilerplate.sh: fix path to script REVERT: 9289fd1 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks REVERT: ad29307 Make the spelling and boilerplate checks optional REVERT: 5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests REVERT: 48186eb Fix spelling and boilerplate errors REVERT: 71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests REVERT: 981be3f Adding spelling and boilerplate checks. REVERT: 2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master REVERT: 3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout REVERT: 9318c6c cloud build: double the timeout, now 1 hour REVERT: 4ab8b15 use the tag to replace commit of csi-test REVERT: 5d74e45 change the csi-test import path to v4 REVERT: 7dcd0a9 upgrade csi-test to v4.0.2 REVERT: 86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name REVERT: c3a9662 allow export image name and registry name REVERT: c6a88c6 Merge pull request kubernetes-csi#113 from xing-yang/install_snapshot_controller REVERT: 45ec4c6 Fix the install of snapshot CRDs and controller REVERT: 5d874cc Merge pull request kubernetes-csi#112 from xing-yang/cleanup REVERT: 79bbca7 Cleanup REVERT: d437673 Merge pull request kubernetes-csi#111 from xing-yang/update_snapshot_v1_rc REVERT: 57718f8 Update snapshot CRD version REVERT: 4aff857 Merge pull request kubernetes-csi#109 from pohly/alpha-test-defaults REVERT: 0427289 Merge pull request kubernetes-csi#110 from pohly/kind-0.9-bazel-build-workaround REVERT: 9a370ab prow.sh: work around "kind build node-image" failure REVERT: 522361e prow.sh: only run alpha tests for latest Kubernetes release REVERT: 22c0395 Merge pull request kubernetes-csi#108 from bnrjee/master REVERT: b5b447b Add go ldflags using LDFLAGS at the time of compilation REVERT: 16f4afb Merge pull request kubernetes-csi#107 from pohly/kind-update git-subtree-dir: release-tools git-subtree-split: 00bc64a9b7c2585676b1da301a7acae8797229a9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR tests that we still use the
vendordirectory even when building with Go 1.13Does this PR introduce a user-facing change?: