Skip to content

master: update release-tools#115

Merged
k8s-ci-robot merged 9 commits into
kubernetes-csi:masterfrom
pohly:prow-update-master
Nov 5, 2019
Merged

master: update release-tools#115
k8s-ci-robot merged 9 commits into
kubernetes-csi:masterfrom
pohly:prow-update-master

Conversation

@pohly

@pohly pohly commented Nov 4, 2019

Copy link
Copy Markdown
Contributor

Commit summary:
8067845 travis.yml: also use vendor directory
23df4ae prow.sh: use vendor directory if available
c8a1c4a better handling of Go version
5e773d2 update CI to use Go 1.13.3
e0fde8c Add new variables for 1.16 and remove 1.13

NONE

msau42 and others added 9 commits October 30, 2019 18:08
Add new variables for 1.16 and remove 1.13
This is the latest release. Updating is useful to ensure that we have
all of the latest fixes and enhancements.
Some operations are sensitive to the version of Go that is used. In
the past, formatting of source differed depending on the
version. Right now it is the content of the vendor directory which
changes when switch back and forth between 1.12 and 1.13.

We don't want to impose a certain workflow on developers, like forcing
all invocations of Go to run inside a container. If developers want
that, they can set up their development environment accordingly.

But we should warn about this aspect to raise awareness. "make"
invocations which involve Go now compare against the projects Go
version (specified in travis.yml) once at the beginning. This is only
a warning because we don't know which future version will be
compatible with the project.

Vendor directory handling gets updated, too: verification is now a
separate script (became too complex for make) and there is a
corresponding "update-vendor.sh". In contrast to verification,
updating vendor is not integrated into make and thus itself invokes
the go version check.
This avoids dependencies on the Go module cache or the upstream code
hosting.
prow.sh: use vendor directory if available
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 4, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 4, 2019
@pohly pohly mentioned this pull request Nov 4, 2019
@msau42

msau42 commented Nov 5, 2019

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2019
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@msau42

msau42 commented Nov 5, 2019

Copy link
Copy Markdown
Collaborator

/test pull-kubernetes-csi-csi-driver-host-path-1-15-on-kubernetes-1-15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants