Add id translation for content/id/docs/concepts/extend-kubernetes#18653
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Jan 15, 2020
antoooks:master
Merged
Add id translation for content/id/docs/concepts/extend-kubernetes#18653k8s-ci-robot merged 1 commit intokubernetes:masterfrom antoooks:master
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
antoooks:master
Conversation
sftim
reviewed
Jan 13, 2020
Contributor
sftim
left a comment
There was a problem hiding this comment.
Hello. Here is some informal feedback that I hope is useful.
I might be wrong about the localization details; I speak English but not bahasa Indonesia.
content/id/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
Outdated
Show resolved
Hide resolved
girikuncoro
requested changes
Jan 14, 2020
Contributor
girikuncoro
left a comment
There was a problem hiding this comment.
Great work on localizing this @antoooks, thanks for the contribution ! 🎉 🎉 just need your opinions on couple of phrases/sentences, then this is good to merge
content/id/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
Outdated
Show resolved
Hide resolved
Contributor
|
/uncc |
Contributor
|
@antoooks looking good, great work! please squash into single commit message, then we can merge this to production /lgtm |
Member
|
/lgtm |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irvifa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
45 tasks
wawa0210
pushed a commit
to wawa0210/website
that referenced
this pull request
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #15341
/assign @girikuncoro
/assign @irvifa