Skip to content

Add note about service CIDR bug to changes#18489

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
saschagrunert:service-cidr-bug
Jan 16, 2020
Merged

Add note about service CIDR bug to changes#18489
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
saschagrunert:service-cidr-bug

Conversation

@saschagrunert
Copy link
Copy Markdown
Member

Analogous change to kubernetes/kubernetes#86759

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 6, 2020
Copy link
Copy Markdown
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

:shipit: 😉

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2020
@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Jan 8, 2020

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2020
@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Jan 8, 2020

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@kbhawkey
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit c4a51a2 into kubernetes:master Jan 16, 2020
@saschagrunert saschagrunert deleted the service-cidr-bug branch January 16, 2020 15:04
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants