Skip to content

CHANGELOG-1.17: add note about service CIDR bug#86759

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
neolit123:1.17-add-known-issues-service-cidr
Jan 3, 2020
Merged

CHANGELOG-1.17: add note about service CIDR bug#86759
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
neolit123:1.17-add-known-issues-service-cidr

Conversation

@neolit123
Copy link
Copy Markdown
Member

@neolit123 neolit123 commented Jan 1, 2020

What this PR does / why we need it:

Adding note to the changelog to notify users about the problem.

original issue:
#86497
fix PR:
#86534
a suspect new issue caused by the same bug:
#86754

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig release network
/kind documentation
/assign @liggitt
@kubernetes/sig-release

@neolit123
CHANGELOG-1.17: add note about service CIDR bug
d8edc7d 
Adding note to the changelog to notify users about the problem.
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 1, 2020

@neolit123: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 1, 2020
@neolit123
Copy link
Copy Markdown
Member Author

neolit123 commented Jan 1, 2020

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 1, 2020
@neolit123
Copy link
Copy Markdown
Member Author

neolit123 commented Jan 1, 2020

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 1, 2020
neolit123
neolit123 commented Jan 1, 2020
View reviewed changes
CHANGELOG-1.17.md

#### Windows
- The Windows containers RunAsUsername feature is now beta.
- The Windows containers RunAsUsername feature is now beta.
Copy link
Copy Markdown
Member Author

@neolit123 neolit123 Jan 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

includes trailing-whitespace cleanup from my editor.

@tanjunchen
Copy link
Copy Markdown
Contributor

tanjunchen commented Jan 2, 2020

/test pull-kubernetes-e2e-gce

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Jan 2, 2020

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2020
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jan 2, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jan 2, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 2, 2020

/sig docs
If this merges, please open an issue against the website to track getting that updated as well.

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 2, 2020
@neolit123
Copy link
Copy Markdown
Member Author

neolit123 commented Jan 2, 2020

@sftim

If this merges, please open an issue against the website to track getting that updated as well.

do you mean documenting that 1.17.0 has the issue and it will be fixed in 1.17.1 in related pages such as https://kubernetes.io/docs/concepts/services-networking/service/#choosing-your-own-ip-address

i don't believe we have done this for PATCH level fixes before.

@saschagrunert
Copy link
Copy Markdown
Member

saschagrunert commented Jan 2, 2020 •
edited
Loading

We will have to fix this for kubernetes.io as well as the relnotes.k8s.io version. No worries, I can take care of this (already on my todo list).

@saschagrunert
Copy link
Copy Markdown
Member

saschagrunert commented Jan 2, 2020

/retest

@alejandrox1
Copy link
Copy Markdown
Contributor

alejandrox1 commented Jan 2, 2020

/test pull-kubernetes-e2e-gce
prev failure https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/86759/pull-kubernetes-e2e-gce/1212851802802753537/

@neolit123
Copy link
Copy Markdown
Member Author

neolit123 commented Jan 2, 2020

pull-kubernetes-e2e-gce seems to be failing every time in a different test:
https://prow.k8s.io/pr-history/?org=kubernetes&repo=kubernetes&pr=86759

[sig-storage] In-tree Volumes [Driver: local][LocalVolumeType: dir-bindmounted] [Testpattern: Pre-provisioned PV (default fs)] subPath should support existing directories when readOnly specified in the volumeSource

[sig-network] Services should have session affinity work for service with type clusterIP [LinuxOnly]

[sig-storage] In-tree Volumes [Driver: local][LocalVolumeType: blockfs] [Testpattern: Pre-provisioned PV (default fs)] volumes should allow exec of files on the volume expand_more 1m37s
[k8s.io] Pods should support pod readiness gates [NodeFeature:PodReadinessGate] expand_mor

[sig-api-machinery] ResourceQuota should create a ResourceQuota and capture the life of a replication controller. [Conformance]

[sig-storage] Projected configMap should be consumable from pods in volume as non-root [NodeConformance] [Conformance] expand_more 49s
[sig-storage] Downward API volume should provide container's cpu limit [NodeConformance] [Conformance] expand_more 43s
[sig-api-machinery] CustomResourcePublishOpenAPI [Privileged:ClusterAdmin] works for multiple CRDs of different groups [Conformance] expand_more

[k8s.io] [sig-node] Pods Extended [k8s.io] Delete Grace Period should be submitted and removed [Conformance] expand_more 1m1s
[sig-storage] In-tree Volumes [Driver: nfs] [Testpattern: Dynamic PV (default fs)] subPath should support readOnly directory specified in the volumeMount expand_more 1m27s

@k8s-ci-robot k8s-ci-robot merged commit 3879095 into kubernetes:master Jan 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 3, 2020
@saschagrunert saschagrunert mentioned this pull request Jan 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@thockin thockin Awaiting requested review from thockin

Assignees

@liggitt liggitt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.18

Development

Successfully merging this pull request may close these issues.

8 participants

@neolit123 @k8s-ci-robot @tanjunchen @liggitt @fejta-bot @sftim @saschagrunert @alejandrox1