Skip to content

Renamed FeatureGate RequestManagement to APIPriorityAndFairness#18184

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
makocchi-git:rename_RequestManagement
Dec 23, 2019
Merged

Renamed FeatureGate RequestManagement to APIPriorityAndFairness#18184
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
makocchi-git:rename_RequestManagement

Conversation

@makocchi-git
Copy link
Copy Markdown
Contributor

RequestManagement was renamed to APIPriorityAndFairness by this PR.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 18, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 18, 2019
@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Dec 18, 2019

/lgtm
PR merged in 1.17 branch: kubernetes/kubernetes@9d0a32c

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2019
@makocchi-git
Copy link
Copy Markdown
Contributor Author

preview is here
original

@inductor
Copy link
Copy Markdown
Member

/assign @gochist

@gochist
Copy link
Copy Markdown
Contributor

gochist commented Dec 18, 2019

/unassign
/assign @kbarnard10

@k8s-ci-robot k8s-ci-robot assigned kbarnard10 and unassigned gochist Dec 18, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2019
@makocchi-git
Copy link
Copy Markdown
Contributor Author

@kbhawkey Thank you for your comments.
I sorted.

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Dec 23, 2019

/lgtm
This change now is more accurate than its original version.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2019
- `AllowExtTrafficLocalEndpoints`: Enable a service to route external requests to node local endpoints.
- `APIListChunking`: Enable the API clients to retrieve (`LIST` or `GET`) resources from API server in chunks.
- `APIPriorityAndFairness`: Enable managing request concurrency with prioritization and fairness at each server.
- `APIPriorityAndFairness`: Enable managing request concurrency with prioritization and fairness at each server. (Renamed from `RequestManagement`)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makocchi-git , Looks good 😃 . One nit:
... fairness at each server. This feature gate is formerly known as RequestManagement.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbhawkey Thank you for your advice👍

@kbhawkey
Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit f1f7c1b into kubernetes:master Dec 23, 2019
@makocchi-git makocchi-git deleted the rename_RequestManagement branch December 24, 2019 01:07
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
…rnetes#18184)

* Renamed FeatureGate RequestManagement to APIPriorityAndFairness

* sorted alphabetically

* wrote RequestManagement into the deprecated table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants