Renamed FeatureGate RequestManagement to APIPriorityAndFairness#85260
Renamed FeatureGate RequestManagement to APIPriorityAndFairness#85260k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
The old name is too broad, we wanted a name that is more specific to the actual feature. This is an alpha gate, and no release has yet associated any functionality with this gate.
|
/retest |
| // | ||
| // Enables managing request concurrency with prioritization and fairness at each server | ||
| RequestManagement featuregate.Feature = "RequestManagement" | ||
| APIPriorityAndFairness featuregate.Feature = "APIPriorityAndFairness" |
There was a problem hiding this comment.
is APIFlowControl a better name?
There was a problem hiding this comment.
I think not. To me, "flow control" still sounds pretty vague; there are many different sorts of flow control that are possible.
|
/retest |
|
/assign @jktomer |
|
@fedebongio: GitHub didn't allow me to assign the following users: jktomer. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| if s.EnableInflightQuotaHandler { | ||
| if !utilfeature.DefaultFeatureGate.Enabled(features.RequestManagement) { | ||
| if !utilfeature.DefaultFeatureGate.Enabled(features.APIPriorityAndFairness) { | ||
| errors = append(errors, fmt.Errorf("--enable-inflight-quota-handler can not be set if feature "+ |
There was a problem hiding this comment.
We should change this flag name, too.
|
I don't know if this is an optimal name but it's lots better than the existing one. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavalamp, MikeSpreitzer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Renamed FeatureGate RequestManagement to APIPriorityAndFairness.
The old name is too broad, we wanted a name that is more specific to
the actual feature.
This is an alpha gate, and no release has yet associated any
functionality with this gate.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @yue9944882
/cc @lavalamp
/cc @deads2k
/cc @yliaog
/cc @aaron-prindle
/cc @mars1024
/sig api-machinery