Skip to content

Add translation for Logging in ID localization#16071

Merged
k8s-ci-robot merged 6 commits intokubernetes:masterfrom
danninov:id_translation_logging
Sep 3, 2019
Merged

Add translation for Logging in ID localization#16071
k8s-ci-robot merged 6 commits intokubernetes:masterfrom
danninov:id_translation_logging

Conversation

@danninov
Copy link
Copy Markdown
Contributor

@danninov danninov commented Aug 25, 2019

This PR Bahasa Indonesia translation for Logging. #15341
/assign @irvifa

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2019
@irvifa
Copy link
Copy Markdown
Member

irvifa commented Aug 25, 2019

@danninov have you tested it on your local?

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 26, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 26, 2019
@irvifa
Copy link
Copy Markdown
Member

irvifa commented Aug 26, 2019

@danninov please use the email you use to sign the CLA in your git loca settings.

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 26, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4a9833d

https://deploy-preview-16071--kubernetes-io-master-staging.netlify.com

@danninov
Copy link
Copy Markdown
Contributor Author

danninov commented Aug 26, 2019

@danninov please use the email you use to sign the CLA in your git loca settings.
I apologize, I was using another computer that using another email. I've fix it. How to make cncf-cla:yes again?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 26, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 26, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 683ea84

https://deploy-preview-16071--kubernetes-io-master-staging.netlify.com

@girikuncoro girikuncoro mentioned this pull request Aug 27, 2019
Closed
45 tasks
irvifa
irvifa suggested changes Sep 2, 2019
View reviewed changes
@irvifa
Copy link
Copy Markdown
Member

irvifa commented Sep 3, 2019

Great job, thanks for your contribution 🎉 🎉

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2019
@irvifa
Copy link
Copy Markdown
Member

irvifa commented Sep 3, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6111ca7 into kubernetes:master Sep 3, 2019
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
@danninov @wahyuoi
Add translation for Logging in ID localization (kubernetes#16071)
882e65b 
* Add id translation for logging

* Fix templating issue

* Fix templating issue

* Fix templating issue

* Add files example for SIG ID logging docs

* Fix id-cluster-logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@girikuncoro girikuncoro Awaiting requested review from girikuncoro

1 more reviewer

@irvifa irvifa irvifa requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@irvifa irvifa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danninov @irvifa @k8s-ci-robot