Add ttlafterfinished for ID localization.#16008
Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom Aug 27, 2019
Merged
Add ttlafterfinished for ID localization.#16008k8s-ci-robot merged 2 commits intokubernetes:masterfrom
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
Conversation
Member
Author
|
/assign @girikuncoro |
45 tasks
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 314316a https://deploy-preview-16008--kubernetes-io-master-staging.netlify.com |
girikuncoro
requested changes
Aug 24, 2019
Contributor
girikuncoro
left a comment
There was a problem hiding this comment.
Great job on translating ttl page! 🎉 Some minor suggestions and typo from me, let me know what you think
content/id/docs/concepts/workloads/controllers/ttlafterfinished.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/workloads/controllers/ttlafterfinished.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/workloads/controllers/ttlafterfinished.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/workloads/controllers/ttlafterfinished.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/workloads/controllers/ttlafterfinished.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/workloads/controllers/ttlafterfinished.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/workloads/controllers/ttlafterfinished.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/workloads/controllers/ttlafterfinished.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/workloads/controllers/ttlafterfinished.md
Outdated
Show resolved
Hide resolved
Member
Author
|
@girikuncoro Fixed in the latest commit. |
Contributor
|
Looking good, great job! /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girikuncoro The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wahyuoi
pushed a commit
to wahyuoi/website
that referenced
this pull request
Sep 9, 2019
* Add ttlafterfinished for ID localization. * Fix consistency of language usage based on review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This address #15341