Skip to content

Adding Bahasa Indonesia translation for cluster networking page#15986

Closed
yofriadi wants to merge 15 commits intokubernetes:masterfrom
yofriadi:id/networking
Closed

Adding Bahasa Indonesia translation for cluster networking page#15986
yofriadi wants to merge 15 commits intokubernetes:masterfrom
yofriadi:id/networking

Conversation

@yofriadi
Copy link
Copy Markdown
Contributor

@yofriadi yofriadi commented Aug 21, 2019

addresses #15341

/language id

@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 21, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 21, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 46a5726

https://deploy-preview-15986--kubernetes-io-master-staging.netlify.com

@girikuncoro girikuncoro requested a review from qbl August 23, 2019 11:47
@girikuncoro
Copy link
Copy Markdown
Contributor

girikuncoro commented Aug 24, 2019

@yofriadi is this a WIP or did you accidentally raise an empty PR? please raise PR when you are ready to avoid confusion or add WIP tag in the title

@yofriadi
Copy link
Copy Markdown
Contributor Author

yofriadi commented Aug 24, 2019

@girikuncoro oh sorry, this is a WIP, will update it soon, thank you.

@irvifa
Copy link
Copy Markdown
Member

irvifa commented Aug 24, 2019

@yofriadi Can you please add a WIP in the title? Thanks..

@girikuncoro girikuncoro changed the title Adding Bahasa Indonesia translation for cluster networking page WIP: Adding Bahasa Indonesia translation for cluster networking page Aug 24, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 7, 2019
@girikuncoro
Copy link
Copy Markdown
Contributor

girikuncoro commented Sep 29, 2019

@yofriadi any update on this?

@girikuncoro girikuncoro mentioned this pull request Sep 29, 2019
Closed
45 tasks
@yofriadi
Copy link
Copy Markdown
Contributor Author

yofriadi commented Sep 29, 2019

@girikuncoro I'm sorry, will work on it this week

@girikuncoro
Copy link
Copy Markdown
Contributor

girikuncoro commented Sep 29, 2019 via email

@irvifa
Copy link
Copy Markdown
Member

irvifa commented Oct 6, 2019

Hi @yofriadi is this already final?

@yofriadi
Copy link
Copy Markdown
Contributor Author

yofriadi commented Oct 6, 2019

@irvifa no not yet, I guess still half way there, I will report if this done, thank you

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/en Issues or PRs related to English language and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2019
@girikuncoro
Copy link
Copy Markdown
Contributor

girikuncoro commented Oct 21, 2019

@yofriadi let us know when it's ready for review

@yofriadi yofriadi changed the title WIP: Adding Bahasa Indonesia translation for cluster networking page Adding Bahasa Indonesia translation for cluster networking page Nov 24, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2019
@yofriadi
Copy link
Copy Markdown
Contributor Author

yofriadi commented Nov 24, 2019

@girikuncoro @irvifa Hi, I finally finish it and ready for review, sorry for being so looong.

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Nov 26, 2019

Please remove 'content/en/docs/concepts/cluster-administration/networking.md ' from your commit. It looks to me irrelevant to your main PR.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 29, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign irvifa
You can assign the PR to them by writing /assign @irvifa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yofriadi
Copy link
Copy Markdown
Contributor Author

yofriadi commented Nov 29, 2019

@tengqm done

@Rajakavitha1
Copy link
Copy Markdown
Contributor

Rajakavitha1 commented Dec 2, 2019 •
edited
Loading

/remove-language en

@k8s-ci-robot k8s-ci-robot removed the language/en Issues or PRs related to English language label Dec 2, 2019
irvifa
irvifa suggested changes Dec 13, 2019
View reviewed changes
content/id/docs/concepts/cluster-administration/networking.md
@@ -0,0 +1,230 @@
---
reviewers:
Copy link
Copy Markdown
Member

@irvifa irvifa Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove reviewers part in here

content/id/docs/concepts/cluster-administration/networking.md

Kubernetes adalah tentang berbagi mesin antar aplikasi. Pada dasarnya,
saat berbagi mesin harus memastikan bahwa dua aplikasi tidak mencoba menggunakan
_port_ yang sama. Mengkoordinasikan _port_ di banyak _developers_ sangat sulit
Copy link
Copy Markdown
Member

@irvifa irvifa Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_port_ yang sama. Mengkoordinasikan _port_ di banyak _developers_ sangat sulit
_port_ yang sama. Mengkoordinasikan _port_ di banyak pengembang sangat sulit

content/id/docs/concepts/cluster-administration/networking.md

Kubernetes adalah tentang berbagi mesin antar aplikasi. Pada dasarnya,
saat berbagi mesin harus memastikan bahwa dua aplikasi tidak mencoba menggunakan
_port_ yang sama. Mengkoordinasikan _port_ di banyak _developers_ sangat sulit
Copy link
Copy Markdown
Member

@irvifa irvifa Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_port_ yang sama. Mengkoordinasikan _port_ di banyak _developers_ sangat sulit
_port_ yang sama. Mengkoordinasikan _port_ di banyak pengembang sangat sulit

content/id/docs/concepts/cluster-administration/networking.md

Kubernetes adalah tentang berbagi mesin antar aplikasi. Pada dasarnya,
saat berbagi mesin harus memastikan bahwa dua aplikasi tidak mencoba menggunakan
_port_ yang sama. Mengkoordinasikan _port_ di banyak _developers_ sangat sulit
Copy link
Copy Markdown
Member

@irvifa irvifa Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_port_ yang sama. Mengkoordinasikan _port_ di banyak _developers_ sangat sulit
_port_ yang sama. Mengkoordinasikan _port_ di banyak pengembang sangat sulit

@irvifa
Copy link
Copy Markdown
Member

irvifa commented Dec 13, 2019

Hi 👋 @yofriadi can you please rebase and squash your commits into one? Thanks

@phanama
Copy link
Copy Markdown
Contributor

phanama commented Jan 13, 2020

Hi @yofriadi 👋
Any updates on this??

@wahyuoi wahyuoi mentioned this pull request Mar 1, 2020
Merged
@girikuncoro
Copy link
Copy Markdown
Contributor

girikuncoro commented Mar 22, 2020

closing this since @wahyuoi has co-author this PR in #19420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@girikuncoro girikuncoro Awaiting requested review from girikuncoro

@qbl qbl Awaiting requested review from qbl

1 more reviewer

@irvifa irvifa irvifa requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yofriadi @girikuncoro @irvifa @tengqm @k8s-ci-robot @Rajakavitha1 @phanama