Skip to content

Adding Bahasa Indonesia translation for certificates page#15769

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
yofriadi:certificates-id
Aug 16, 2019
Merged

Adding Bahasa Indonesia translation for certificates page#15769
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
yofriadi:certificates-id

Conversation

@yofriadi
Copy link
Copy Markdown
Contributor

@yofriadi yofriadi commented Aug 9, 2019

addresses #15341

/language id
/assign @girikuncoro
/assign @irvifa

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 9, 2019

Welcome @yofriadi!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2019
@yofriadi yofriadi mentioned this pull request Aug 9, 2019
Closed
45 tasks
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 9, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 259c377

https://deploy-preview-15769--kubernetes-io-master-staging.netlify.com

@danninov
Copy link
Copy Markdown
Contributor

danninov commented Aug 9, 2019

/assign @danninov

danninov
danninov suggested changes Aug 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@danninov danninov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I like your translation. You can improved it by rearrange and/or add some other words than can add context that easier for reader to understand. Keep it up!

@yofriadi
Copy link
Copy Markdown
Contributor Author

yofriadi commented Aug 9, 2019

Hi @danninov I'm curious if there is any standardization process on how to decide to pick one over another in PR or we just trusts the reviewer.
Also one thing since I have involved in this project, may I get write permissions for the glossary, there is some word that don't appear in glossary but shows up in here and get directed to be translated on some word, I think I should contribute to that too.

Thank you

@danninov
Copy link
Copy Markdown
Contributor

danninov commented Aug 10, 2019

Hi @danninov I'm curious if there is any standardization process on how to decide to pick one over another in PR or we just trusts the reviewer.
Also one thing since I have involved in this project, may I get write permissions for the glossary, there is some word that don't appear in glossary but shows up in here and get directed to be translated on some word, I think I should contribute to that too.

Thank you

Do you mean whether to accept the suggestion from reviewer or reject it? As far as I know, there is no standardization yet. For more discussion please go to our Slack Channel

@irvifa
Copy link
Copy Markdown
Member

irvifa commented Aug 10, 2019

@yofriadi Hi, it’s on kubernetes’ slack channel sig-docs-id once the review process is over the reviewer can ping me or Giri to approve the PR so that it’ll be merged into master. Cheers..

@yofriadi
Copy link
Copy Markdown
Contributor Author

yofriadi commented Aug 13, 2019

Hi @danninov I have updated the translation based on your suggestion. Thank you.

@girikuncoro
Copy link
Copy Markdown
Contributor

girikuncoro commented Aug 16, 2019

Great work @yofriadi , thanks for your contribution! 🎉 We are very happy if you could help us translate other pages as well 😄

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0e319ba into kubernetes:master Aug 16, 2019
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
@yofriadi @wahyuoi
Adding Bahasa Indonesia translation for certificates page (kubernetes…
0b600b5 
…#15769)

* Add Bahasa Indonesia translation for certificates page

* Untranslated title

* Updating translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@girikuncoro girikuncoro Awaiting requested review from girikuncoro

@irvifa irvifa Awaiting requested review from irvifa

1 more reviewer

@danninov danninov danninov requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@girikuncoro girikuncoro

@irvifa irvifa

@danninov danninov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yofriadi @k8s-ci-robot @danninov @irvifa @girikuncoro