Skip to content

Add Indonesian translation for volume-snapshot-classes#15724

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
girikuncoro:volume-snapshot-classes-id
Aug 19, 2019
Merged

Add Indonesian translation for volume-snapshot-classes#15724
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
girikuncoro:volume-snapshot-classes-id

Conversation

@girikuncoro
Copy link
Copy Markdown
Contributor

This PR translates volume-snapshot-classes to Bahasa Indonesia. Part of #15341

/language id
/assign @irvifa

@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 7, 2019
@k8s-ci-robot k8s-ci-robot requested review from irvifa and jimangel August 7, 2019 16:49
@girikuncoro girikuncoro removed the request for review from jimangel August 7, 2019 16:49
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 7, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 97c5357

https://deploy-preview-15724--kubernetes-io-master-staging.netlify.com

@@ -0,0 +1,58 @@
---
title: Volume Snapshot Class
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Volume Snapshot Class
title: VolumeSnapshotClass

(because VolumeSnapshotClass is the unlocalizable resource name)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 97c5357

@girikuncoro girikuncoro requested a review from danninov August 16, 2019 09:27
Copy link
Copy Markdown
Contributor

@danninov danninov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some revision


VolumeSnapshotClass memiliki parameter-parameter yang menggambarkan _snapshot_ volume
di dalam VolumeSnapshotClass. Parameter-parameter yang berbeda diperbolehkan tergantung
dari `shapshotter`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some consitency here, wheter to use italic (like line 49) or code style.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 97c5357


## Pengenalan

Seperti halnya StorageClass yang menyediakan cara untuk para admin mendefinisikan
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...yang menyediakan cara bagi admin untuk mendefinisikan..

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 97c5357

Nama yang dimiliki suatu objek VolumeSnapshotClass sangatlah penting, karena digunakan
oleh pengguna saat meminta sebuah kelas tertentu. Admin dapat mengatur nama dan parameter
lainnya dari sebuah kelas saat pertama kali membuat objek VolumeSnapshotClass. Objek
tidak dapat diperbarui setelah dibuat.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer 'diubah' instead diperbarui

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 97c5357

Copy link
Copy Markdown
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🎉 However I'd like to make the styling consistent with https://kubernetes.io/docs/concepts/storage/volume-snapshot-classes/. Also I suggest few wording for the statements.

{{% capture overview %}}

Laman ini menjelaskan tentang konsep VolumeSnapshotClass pada Kubernetes. Sebelum melanjutkan,
sangat disarankan untuk membaca [_snapshot_ volume](/docs/concepts/storage/volume-snapshots/)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snapshot volume -> volume snapshot

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for Indonesian language it's the opposite, it's like:
Language Class (en) -> Kelas Bahasa (id)

order becomes opposite


{{% capture overview %}}

Laman ini menjelaskan tentang konsep VolumeSnapshotClass pada Kubernetes. Sebelum melanjutkan,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VolumeSnapshotClass -> VolumeSnapshotClass

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original page styling is incorrect, for resource name it should be camel case according to https://kubernetes.io/docs/contribute/style/style-guide/#use-camel-case-for-api-objects


## Pengenalan

Seperti halnya StorageClass yang menyediakan cara untuk para admin mendefinisikan
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StorageClass -> StorageClass

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original page styling is incorrect, for resource name it should be camel case according to https://kubernetes.io/docs/contribute/style/style-guide/#use-camel-case-for-api-objects

## Pengenalan

Seperti halnya StorageClass yang menyediakan cara untuk para admin mendefinisikan
"kelas" penyimpanan yang mereka tawarkan saat proses penyediaan sebuah volume, VolumeSnapshotClass
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VolumeSnapshotClass -> VolumeSnapshotClass

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original page styling is incorrect, for resource name it should be camel case according to https://kubernetes.io/docs/contribute/style/style-guide/#use-camel-case-for-api-objects


Seperti halnya StorageClass yang menyediakan cara untuk para admin mendefinisikan
"kelas" penyimpanan yang mereka tawarkan saat proses penyediaan sebuah volume, VolumeSnapshotClass
menyediakan cara untuk mendefinisikan "kelas" penyimpanan saat menyediakan _snapshot_ volume.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snapshot volume. -> volume snapshot

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for Indonesian language it's the opposite, it's like:
Language Class (en) -> Kelas Bahasa (id)

order becomes opposite

yang digunakan saat sebuah VolumeSnapshot yang dimiliki kelas tersebut perlu untuk
disediakan secara dinamis.

Nama yang dimiliki suatu objek VolumeSnapshotClass sangatlah penting, karena digunakan
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VolumeSnapshot -> VolumeSnapshot

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original page styling is incorrect, for resource name it should be camel case according to https://kubernetes.io/docs/contribute/style/style-guide/#use-camel-case-for-api-objects


Nama yang dimiliki suatu objek VolumeSnapshotClass sangatlah penting, karena digunakan
oleh pengguna saat meminta sebuah kelas tertentu. Admin dapat mengatur nama dan parameter
lainnya dari sebuah kelas saat pertama kali membuat objek VolumeSnapshotClass. Objek
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VolumeSnapshotClass -> VolumeSnapshotClass

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original page styling is incorrect, for resource name it should be camel case according to https://kubernetes.io/docs/contribute/style/style-guide/#use-camel-case-for-api-objects

lainnya dari sebuah kelas saat pertama kali membuat objek VolumeSnapshotClass. Objek
tidak dapat diperbarui setelah dibuat.

Admin dapat mengatur VolumeSnapshotClass _default_ hanya untuk VolumeSnapshot yang tidak
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VolumeSnapshotClass -> VolumeSnapshotClass

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hanya untuk -> untuk

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meminta kelas apapun untuk dikaitkan. -> yang tidak memiliki menspesifikan kelas apapun

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 97c5357


### _Snapshotter_

VolumeSnapshotClass memiliki sebuah _snapshotter_ yang menentukan volume CSI plugin
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VolumeSnapshotClass -> VolumeSnapshotClass

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSI plugin -> plugin CSI

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 97c5357

### _Snapshotter_

VolumeSnapshotClass memiliki sebuah _snapshotter_ yang menentukan volume CSI plugin
apa yang digunakan untuk penyediaan VolumeSnapshot. _Field_ ini wajib diatur.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VolumeSnapshot -> VolumeSnapshot

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original page styling is incorrect, for resource name it should be camel case according to https://kubernetes.io/docs/contribute/style/style-guide/#use-camel-case-for-api-objects

@irvifa
Copy link
Copy Markdown
Member

irvifa commented Aug 19, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2019
@irvifa
Copy link
Copy Markdown
Member

irvifa commented Aug 19, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit b999f0d into kubernetes:master Aug 19, 2019
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
)

* Add Indonesian translation for volume-snapshot-classes

* Fix page styling consistency and wordings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants