Skip to content

Add Indonesian translation for container runtime class#14222

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
girikuncoro:runtime-class
May 8, 2019
Merged

Add Indonesian translation for container runtime class#14222
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
girikuncoro:runtime-class

Conversation

@girikuncoro
Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro commented May 8, 2019

This PR adds Indonesian translation for container runtime class, addresses #13929

/language id
/assign @irvifa

@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 8, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 8, 2019
@girikuncoro girikuncoro removed the request for review from xiangpengzhao May 8, 2019 03:34
@girikuncoro girikuncoro mentioned this pull request May 8, 2019
Closed
80 tasks
@netlify
Copy link
Copy Markdown

netlify bot commented May 8, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 07b5b58

https://deploy-preview-14222--kubernetes-io-master-staging.netlify.com

irvifa
irvifa suggested changes May 8, 2019
View reviewed changes
irvifa
irvifa reviewed May 8, 2019
View reviewed changes
@irvifa
Copy link
Copy Markdown
Member

irvifa commented May 8, 2019

Overall it's already good 🎉 let me know about your opinion later. Thanks. Also per new styling guide we're using _ for italic *. And retaining the usage of ** for bold.

@girikuncoro
Copy link
Copy Markdown
Contributor Author

girikuncoro commented May 8, 2019

@irvifa comments are all addressed and italic format has been changed from single asterisk to underscore

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2019
irvifa
irvifa reviewed May 8, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7327c65 into kubernetes:master May 8, 2019
yoonian pushed a commit to yoonian/kubernetes-website that referenced this pull request May 28, 2019
@girikuncoro @yoonian
Add Indonesian translation for container runtime class (kubernetes#14222
8a8adbf 
)

* Add Indonesian translation for container runtime class

* Address broken links and backticks

* Change single asterisk to underscore for italic format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@irvifa irvifa irvifa requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@irvifa irvifa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@girikuncoro @irvifa @k8s-ci-robot