Skip to content

Add content/es/docs/tasks/tools/install minikube.md#13658

Closed
emedina wants to merge 13 commits intokubernetes:masterfrom
emedina:es/docs/tasks/tools/install-minikube.md
Closed

Add content/es/docs/tasks/tools/install minikube.md#13658
emedina wants to merge 13 commits intokubernetes:masterfrom
emedina:es/docs/tasks/tools/install-minikube.md

Conversation

@emedina
Copy link
Copy Markdown
Contributor

@emedina emedina commented Apr 7, 2019

Spanish translation

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 7, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 7, 2019
@k8s-ci-robot k8s-ci-robot requested review from glo-pena and raelga April 7, 2019 13:07
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 7, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 7, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0872a1c

https://deploy-preview-13658--kubernetes-io-master-staging.netlify.com

@raelga
Copy link
Copy Markdown
Member

raelga commented Apr 7, 2019

Thanks for the translation @emedina, looks great!

Please squash the commits under the user that signed the CLA to be able to pass that check.

@emedina emedina force-pushed the es/docs/tasks/tools/install-minikube.md branch from c4fd888 to 5f8fb47 Compare April 7, 2019 13:19
raelga
raelga reviewed Apr 7, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is missing the author, please try to squash all 3 in a single commit with the @emedina GitHub user.

Thanks!

Enrique Medina Montenegro added 2 commits April 7, 2019 16:57
@emedina emedina force-pushed the es/docs/tasks/tools/install-minikube.md branch from 9ccd835 to 1ea8da3 Compare April 7, 2019 14:59
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 7, 2019
@emedina
Copy link
Copy Markdown
Contributor Author

emedina commented Apr 8, 2019

/assign @raelga

raelga
raelga reviewed Apr 8, 2019
View reviewed changes
@k8s-ci-robot k8s-ci-robot added the language/es Issues or PRs related to Spanish language label Apr 9, 2019
@emedina
Copy link
Copy Markdown
Contributor Author

emedina commented Apr 9, 2019

/assign @raelga

@raelga
Copy link
Copy Markdown
Member

raelga commented Apr 9, 2019

Muchísimas gracias @emedina, solo quedaría lo que hemos comentado en #13659 para construir el árbol del índice.

El problema es que habrá que integrarlo primero y luego tendrás que hacer un rebase de tu fork para poder mergear esta PR sin conflictos.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 11, 2019
@emedina
Copy link
Copy Markdown
Contributor Author

emedina commented Apr 11, 2019

/assign @raelga

@raelga
Copy link
Copy Markdown
Member

raelga commented Apr 11, 2019

Buenas @emedina, en esta PR ahora mismo hay dos documentos, minikube y kubectl. El segundo ya se está tratando en #13659, dónde además también incluye el árbol del índice. Si te parece bien, vamos avanzando la otra PR y cuando esté desplegada, retomamos esta PR únicamente con el documento de minikube.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 15, 2019

@seomago: changing LGTM is restricted to assignees, and only kubernetes/website repo collaborators may be assigned issues.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@raelga
Copy link
Copy Markdown
Member

raelga commented Apr 15, 2019

@emedina aún hay un conflicto con content/es/docs/tasks/_index.md, lo puedes revisar?

Por otro lado, con tanto cambio ha quedado en 9 commits, ¿Lo puedes squashear en uno solo de cara al merge?

Gracias!

Enrique Medina Montenegro and others added 3 commits April 16, 2019 09:20
Spanish translation
5da0820
@escalant3
Create ES resource-metrics-pipeline.md (kubernetes#13648)
8711bab 
Add correct index file
@proth1
the sentence does not make sense (kubernetes#12673)
c16e561 
I've attempted to have it make more sense by removing the word 'is'.  Optionally, depending on the intended meaning, the sentence could read differently by leaving the word 'is' alone and changing the word 'through' to 'though'.

Spanish translation

Spanish translation
electrocucaracha
electrocucaracha reviewed Apr 16, 2019
View reviewed changes
glo-pena
glo-pena reviewed Apr 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@glo-pena glo-pena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Una pequeña pequeña corrección más, lo siento. Después estaría lista para aprobar. Muchas gracias por tu paciencia y todos los arreglos.

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Apr 17, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 17, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kbarnard10

If they are not already assigned, you can assign the PR to them by writing /assign @kbarnard10 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

glo-pena
glo-pena approved these changes Apr 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@glo-pena glo-pena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2019
@electrocucaracha
Copy link
Copy Markdown
Contributor

electrocucaracha commented Apr 17, 2019

/lgtm

@glo-pena
Copy link
Copy Markdown
Contributor

glo-pena commented Apr 17, 2019

@emedina imagino que @raelga necesitará que arregles el conflicto y que hagas un squash antes de poder mergear? Mergear suena fatal.. anyway cuando lo tengas añade un comentario de asignación. Dedos cruzados! A ver si sacamos este adelante.

@raelga
Copy link
Copy Markdown
Member

raelga commented Apr 17, 2019 •
edited
Loading

@emedina Lo miramos por slack para limpiar un poco la PR, hacer un rebase al upstream y solo commitear el fichero en cuestión. Cuando tengas un momento lo hacemos y mergeamos ésta PR.

@Bradamant3
Copy link
Copy Markdown
Contributor

Bradamant3 commented Apr 19, 2019

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2019
@Bradamant3
Copy link
Copy Markdown
Contributor

Bradamant3 commented Apr 19, 2019

@emedina please resolve conflicts. Please also do not touch any English files. Right now this PR removes a required English file (en/docs/tasks/_index.md)

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2019
@raelga raelga changed the title Es/docs/tasks/tools/install minikube.md Add /es/docs/tasks/tools/install minikube.md Apr 19, 2019
@emedina emedina closed this Apr 22, 2019
@emedina emedina deleted the es/docs/tasks/tools/install-minikube.md branch April 22, 2019 07:43
@raelga
Copy link
Copy Markdown
Member

raelga commented Apr 22, 2019

@electrocucaracha and @glo-pena, this PR has been superseded by #13946.

@raelga raelga changed the title Add /es/docs/tasks/tools/install minikube.md Add content/es/docs/tasks/tools/install minikube.md Apr 22, 2019
@raelga raelga added this to the KubeCon EU 2019 milestone May 1, 2019
@raelga
Copy link
Copy Markdown
Member

raelga commented May 3, 2019

Tracked in #13948

@emedina emedina mentioned this pull request Jul 6, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raelga raelga raelga left review comments

+2 more reviewers

@electrocucaracha electrocucaracha electrocucaracha left review comments

@glo-pena glo-pena glo-pena approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@glo-pena glo-pena

@raelga raelga

@electrocucaracha electrocucaracha

@Bradamant3 Bradamant3

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Spanish M1

Development

Successfully merging this pull request may close these issues.

9 participants

@emedina @k8s-ci-robot @raelga @seomago @electrocucaracha @glo-pena @Bradamant3 @escalant3 @proth1