the sentence does not make sense#12673
the sentence does not make sense#12673k8s-ci-robot merged 1 commit intokubernetes:masterfrom proth1:patch-1
Conversation
I've attempted to have it make more sense by removing the word 'is'. Optionally, depending on the intended meaning, the sentence could read differently by leaving the word 'is' alone and changing the word 'through' to 'though'.
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 3806e6f https://deploy-preview-12673--kubernetes-io-master-staging.netlify.com |
|
/check-cla |
|
Thanks for the PR @proth1!!!Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). memo Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks. |
|
I signed the CLA. Thanks |
|
/check-cla |
|
Hey there! @proth1, looks like you haven't signed the CLA yet. Could I please have you do that? https://github.com/kubernetes/community/blob/master/CLA.md |
|
sorry. I thought I had signed but now I have definitely signed the CLA. |
|
Thanks for the PR @proth1 !!!! I guess the intent was: An optional host. In this example, no host is specified, so the rule applies to all inbound HTTP traffic though the IP address is specified. @zparnold could you please take a look at this PR. |
|
/assign @chenopis |
|
@chenopis could you please take a look at this PR and confirm the intent. |
|
IMO， the fix is wrong |
|
It looks to me as though the original indeed does not make sense, as the author points out, but the fix doesn't clear anything up, either. I don't know enough about Ingress to suggest the right fix, but page context suggests that without the optional host, traffic is routed through the default backend. With or without the fix, the doc as is also suggests that the HTTP IP address (specified in the Service spec?) is used in place of the optional host. |
|
@proth1 @stewart-yu would it be more technically accurate if it was "the rule applies to all inbound HTTP traffic through the Kubernetes node"? |
|
/hold until feedback is addressed |
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I've attempted to have it make more sense by removing the word 'is'. Optionally, depending on the intended meaning, the sentence could read differently by leaving the word 'is' alone and changing the word 'through' to 'though'. Spanish translation Spanish translation
I've attempted to have it make more sense by removing the word 'is'. Optionally, depending on the intended meaning, the sentence could read differently by leaving the word 'is' alone and changing the word 'through' to 'though'.
I've attempted to have it make more sense by removing the word 'is'. Optionally, depending on the intended meaning, the sentence could read differently by leaving the word 'is' alone and changing the word 'through' to 'though'.
I've attempted to have it make more sense by removing the word 'is'. Optionally, depending on the intended meaning, the sentence could read differently by leaving the word 'is' alone and changing the word 'through' to 'though'.
I've attempted to have it make more sense by removing the word 'is'. Optionally, depending on the intended meaning, the sentence could read differently by leaving the word 'is' alone and changing the word 'through' to 'though'.