Skip to content

Add kind/api-change as org-wide kind/ label, merge in kind/new-api#8990

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
spiffxp:kind-api-change
Aug 17, 2018
Merged

Add kind/api-change as org-wide kind/ label, merge in kind/new-api#8990
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
spiffxp:kind-api-change

Conversation

@spiffxp

@spiffxp spiffxp commented Aug 9, 2018

Copy link
Copy Markdown
Contributor

The api review process is being worked on right now, and it sounds like
the folks reviewing that are fine with merging the kind/new-api label
into kind/api-change

ref: kubernetes/community#2433 (comment)

Based on discussion in kubernetes/community#2032 I
am assuming we're fine making kind/api-change a standard org-wide label

Fixes: kubernetes/community#2013

/hold
for comment, and I need time to see if there is automation that produces these
labels that should also be updated

/sig contributor-experience
/area github-management
/cc @cblecker @jberkus
/sig architecture
/cc @jdumars @thockin

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2018
@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 9, 2018
@spiffxp spiffxp mentioned this pull request Aug 9, 2018
Merged
@cblecker

cblecker commented Aug 9, 2018

Copy link
Copy Markdown
Member

/hold
explicit hold ^^
Yes, there is automation that does these. It was the path-label munger previously, but I think it might be owners-label now.

@jdumars

jdumars commented Aug 9, 2018

Copy link
Copy Markdown
Contributor

/lgtm
for when the hold is lifted

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2018
@spiffxp

spiffxp commented Aug 10, 2018

Copy link
Copy Markdown
Contributor Author

These haven't been converted to OWNERS files yet, let me do that first

mungegithub/misc-mungers/deployment/kubernetes/path-label.txt
10:^pkg/api/([^/]+/)?types.go$    kind/api-change
11:^pkg/api/([^/]+/)?register.go$ kind/new-api
16:^pkg/apis/[^/]+/([^/]+/)?types.go$    kind/api-change
17:^pkg/apis/[^/]+/([^/]+/)?register.go$ kind/new-api

@spiffxp spiffxp mentioned this pull request Aug 10, 2018
Closed
@spiffxp

spiffxp commented Aug 10, 2018

Copy link
Copy Markdown
Contributor Author

The path-label munger has been turned off #9010

Now to figure out why verify isn't happy with me

@k8s-ci-robot k8s-ci-robot added area/label_sync Issues or PRs related to code in /label_sync and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 10, 2018
cblecker
cblecker approved these changes Aug 10, 2018
View reviewed changes

@cblecker cblecker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2018
@jberkus

jberkus commented Aug 11, 2018

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot

k8s-ci-robot commented Aug 11, 2018

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jberkus, jdumars, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jdumars

jdumars commented Aug 11, 2018

Copy link
Copy Markdown
Contributor

@cblecker have you found any broken dependencies on this change yet?

@spiffxp

spiffxp commented Aug 13, 2018

Copy link
Copy Markdown
Contributor Author

I'm planning on deploying after 3pm PT today if there are no objections

kubernetes-dev@ notification

@cblecker

cblecker commented Aug 16, 2018

Copy link
Copy Markdown
Member

@spiffxp 🕒

@spiffxp

spiffxp commented Aug 17, 2018

Copy link
Copy Markdown
Contributor Author

/hold cancel
😄 thanks for the poke

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5794c89 into kubernetes:master Aug 17, 2018
@k8s-ci-robot

k8s-ci-robot commented Aug 17, 2018

Copy link
Copy Markdown
Contributor

@spiffxp: Updated the label-config configmap using the following files:

  • key labels.yaml using file label_sync/labels.yaml
Details

In response to this:

The api review process is being worked on right now, and it sounds like
the folks reviewing that are fine with merging the kind/new-api label
into kind/api-change

ref: kubernetes/community#2433 (comment)

Based on discussion in kubernetes/community#2032 I
am assuming we're fine making kind/api-change a standard org-wide label

Fixes: kubernetes/community#2013

/hold
for comment, and I need time to see if there is automation that produces these
labels that should also be updated

/sig contributor-experience
/area github-management
/cc @cblecker @jberkus
/sig architecture
/cc @jdumars @thockin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the kind-api-change branch August 17, 2018 01:46
This was referenced Aug 29, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cblecker cblecker cblecker approved these changes

@jberkus jberkus Awaiting requested review from jberkus

@thockin thockin Awaiting requested review from thockin

+1 more reviewer

@jdumars jdumars jdumars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jberkus jberkus

@jdumars jdumars

@cblecker cblecker

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spiffxp @cblecker @jdumars @jberkus @k8s-ci-robot