Skip to content

Disable the path-label munger#9010

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
spiffxp:disable-path-label-munger
Aug 10, 2018
Merged

Disable the path-label munger#9010
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
spiffxp:disable-path-label-munger

Conversation

@spiffxp

@spiffxp spiffxp commented Aug 10, 2018

Copy link
Copy Markdown
Contributor

We can implement equivalent functionality with OWNERS files in the
repo(s) of choice

ref: #9007

/hold
Wait until kubernetes/kubernetes#67275 is merged

/assign @cjwagner

We can implement equivalent functionality with OWNERS files in the
repo(s) of choice
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 10, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 10, 2018

@cjwagner cjwagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2018
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp

spiffxp commented Aug 10, 2018

Copy link
Copy Markdown
Contributor Author

kubernetes/kubernetes#67275 merged

Leaving it to @cjwagner to to /hold cancel

@cjwagner

Copy link
Copy Markdown
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2018
@k8s-ci-robot k8s-ci-robot merged commit e0170c9 into kubernetes:master Aug 10, 2018
@spiffxp spiffxp deleted the disable-path-label-munger branch August 10, 2018 23:00
@cjwagner

Copy link
Copy Markdown
Member

This is deployed. The munger is still doing its first sync loop, but I don't anticipate problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants