Use OWNERS-based labeling for kind/api-change#67275
Conversation
2fa3502 to
5d55216
Compare
There was a problem hiding this comment.
The original regexes started with ^pkg/api/ but AIUI this takes effect relative to the location of this OWNERS file
|
/retest |
This replaces the following path-label munger config, except we're using kind/api-change for everything instead of two different kind/ labels ``` ^pkg/api/([^/]+/)?types.go$ kind/api-change ^pkg/api/([^/]+/)?register.go$ kind/new-api ^pkg/apis/[^/]+/([^/]+/)?types.go$ kind/api-change ^pkg/apis/[^/]+/([^/]+/)?register.go$ kind/new-api ```
5d55216 to
d0b2595
Compare
cjwagner
left a comment
There was a problem hiding this comment.
/lgtm
/hold
We should enable the verify-owners plugin across the kubernetes org so that we can be more confident that these kinds of PRs won't break OWNERS file parsing.
It is probably stable now.
|
Change LGTM - I have precious little context on the hold, though. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, spiffxp, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
This replaces the following path-label munger config, except
we're using kind/api-change for everything instead of two
different kind/ labels
This fixes kubernetes/test-infra#9007
Special notes for your reviewer:
This can be merged independently of us turning path-label off of
mungegithub. While both labeling options are active, they won't
clash, just race.