Enable trigger_github_workflows for controller-runtime and controller…#36752
Conversation
|
Welcome @karimzakzouk! |
|
Hi @karimzakzouk. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test /assign @alvaroaleman /assign @dims |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, karimzakzouk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@karimzakzouk: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Enables trigger_github_workflows: true for kubernetes-sigs/controller-runtime
and kubernetes-sigs/controller-tools so that Prow natively handles workflow
approvals when /ok-to-test is added, allowing removal of the custom
pr-gh-workflow-approve.yaml workflow in those repos.
Which issue(s) this PR fixes:
Part of kubernetes-sigs/cluster-api#13532