Skip to content

Enable trigger_github_workflows for controller-runtime and controller…#36752

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
karimzakzouk:enable-gh-workflows-controller-repos
Apr 2, 2026
Merged

Enable trigger_github_workflows for controller-runtime and controller…#36752
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
karimzakzouk:enable-gh-workflows-controller-repos

Conversation

@karimzakzouk

@karimzakzouk karimzakzouk commented Apr 2, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:
Enables trigger_github_workflows: true for kubernetes-sigs/controller-runtime
and kubernetes-sigs/controller-tools so that Prow natively handles workflow
approvals when /ok-to-test is added, allowing removal of the custom
pr-gh-workflow-approve.yaml workflow in those repos.

Which issue(s) this PR fixes:
Part of kubernetes-sigs/cluster-api#13532

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @karimzakzouk!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 2, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @karimzakzouk. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 2, 2026
@karimzakzouk karimzakzouk reopened this Apr 2, 2026
@sbueringer

Copy link
Copy Markdown
Member

/ok-to-test
/lgtm

/assign @alvaroaleman

/assign @dims

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 2, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 2, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2026
@dims

dims commented Apr 2, 2026

Copy link
Copy Markdown
Member

/approve
/lgtm

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, karimzakzouk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2026
@k8s-ci-robot k8s-ci-robot merged commit 0f81e8d into kubernetes:master Apr 2, 2026
5 checks passed
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@karimzakzouk: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml
Details

In response to this:

What this PR does / why we need it:
Enables trigger_github_workflows: true for kubernetes-sigs/controller-runtime
and kubernetes-sigs/controller-tools so that Prow natively handles workflow
approvals when /ok-to-test is added, allowing removal of the custom
pr-gh-workflow-approve.yaml workflow in those repos.

Which issue(s) this PR fixes:
Part of kubernetes-sigs/cluster-api#13532

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants