Skip to content

Migrate away from custom GitHub action approval workflow #13532

@sbueringer

Description

@sbueringer

A while ago we added this GitHub action (https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/workflows/pr-gh-workflow-approve.yaml) to automatically approve GitHub actions to run when /ok-to-test is added.

Recently Prow was improved to do this automatically: kubernetes-sigs/prow#194

We should take a closer look at kubernetes-sigs/prow#612, enable the feature for CAPI and then remove our custom worfklow

We should migrate away (at least) in the following repos: (once we verified with the CAPI repo that it works as expected)

  • cluster-api
  • cluster-api-provider-vsphere
  • controller-runtime
    • Enable trigger_github_workflows in test-infra
  • controller-tools
    • Enable trigger_github_workflows in test-infra

(Just listing some repos that I'm aware of)

Metadata

Metadata

Assignees

Labels

help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.priority/backlogHigher priority than priority/awaiting-more-evidence.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions