remove recently deleted featuregates from test configs#34374
remove recently deleted featuregates from test configs#34374k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
k/k master recently got rid of the DisableCloudProviders, DisableKubeletCloudCredentialProviders feature gates. Remove them from job configs to fix the jobs.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
elmiko
left a comment
There was a problem hiding this comment.
i'm not familiar with these configuration, but the removals look accurate with the feature gates that are removed.
| "--gce-service-account=default", | ||
| ], | ||
| kubernetes_feature_gates="AllAlpha,DisableCloudProviders,DisableKubeletCloudCredentialProviders,-EventedPLEG", | ||
| kubernetes_feature_gates="AllAlpha,-EventedPLEG", |
There was a problem hiding this comment.
BTW It's make -C config/jobs/kubernetes/kops, or make -C config/jobs/kubernetes/kops generate-jobs if you don't have AWS credentials. (Maybe we should make that the default ... though I would quite like a job that would periodically run invalidate-pins in that case)
https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/kops/Makefile
|
@stlaz: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Yes, LGTM. If you specify the feature flags, kOps will pass them down. We generally obey what they user explicitly tells us. If we know something is totally wrong (e.g. this feature flag no longer exists in this k8s version) we can add a validation or a warning, but we prefer only to do that for things that are commonly encountered. In this case, feature flags feel like something that most end users don't often specify, and probably doesn't warrant double-checking the user. But of course if we think this is something users will encounter, it's not too hard to add some validation! |
|
The PR merged before I managed to push removals of the However, such a change would likely still depend on kubernetes/kops#17270 |
k/k master recently got rid of the DisableCloudProviders, DisableKubeletCloudCredentialProviders feature gates. Remove them from job configs to fix the jobs.
k/k change that broke these: kubernetes/kubernetes#130162
Fixes permafails in:
https://testgrid.k8s.io/amazon-ec2#ci-kubernetes-e2e-ec2-alpha-enabled-default
https://testgrid.k8s.io/amazon-ec2#ci-kubernetes-e2e-ec2-alpha-features
https://testgrid.k8s.io/kops-gce#ci-kubernetes-e2e-cos-gce-alpha-features
https://testgrid.k8s.io/sig-node-presubmits#pr-kubelet-gce-cluster-e2e-credential-provider