Remove cloud-config and cloud-provider from 1.33 apiserver#17270
Merged
k8s-ci-robot merged 4 commits intokubernetes:masterfrom Feb 22, 2025
Merged
Remove cloud-config and cloud-provider from 1.33 apiserver#17270k8s-ci-robot merged 4 commits intokubernetes:masterfrom
k8s-ci-robot merged 4 commits intokubernetes:masterfrom
Conversation
Member
Author
|
/retest |
elmiko
reviewed
Feb 20, 2025
| c.CloudProvider = "external" | ||
| default: | ||
| return fmt.Errorf("unknown cloudprovider %q", cluster.GetCloudProvider()) | ||
| } |
There was a problem hiding this comment.
i'm not sure how this c.CloudProvider value is used, but we do not allow any value other than external for the --cloud-provider flag.
edit: for kube versions >= 1.31
Member
Author
|
/test pull-kops-e2e-k8s-ci |
hakman
approved these changes
Feb 21, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/test all |
This was referenced Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17267