Add Port configuration to ServiceReference of Admission webhooks, CRD Conversion Webhooks, AuditSink Webhooks and kube-aggregator#74855
Merged
k8s-ci-robot merged 7 commits intokubernetes:masterfrom Apr 8, 2019
Conversation
liggitt
reviewed
Mar 2, 2019
staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1/defaults.go
Outdated
Show resolved
Hide resolved
liggitt
reviewed
Mar 2, 2019
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
yue9944882
reviewed
Mar 4, 2019
liggitt
reviewed
Mar 4, 2019
Member
There was a problem hiding this comment.
drop the default comment from the internal versions, defaults only apply to external versions
Contributor
Author
|
/retest |
liggitt
reviewed
Mar 4, 2019
Member
There was a problem hiding this comment.
a 1.14-level aggregated API server running against an n-1 kube-apiserver would panic here, right?
Contributor
Author
There was a problem hiding this comment.
v1beta1.Webhook is an admissionregistration object that should have been stored or accepted by the user. In both cases it will be defaulted before it gets here. how does it panic here?
Contributor
Author
|
@liggitt PTAL |
Contributor
Author
|
/hold cancel |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, mbohlool The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Is this going to be cherry picked back to any 1.13 or 1.14 releases? If it's not currently planned to be, can it be? |
Member
|
no. new features/capabilities are not backported, just bug/security fixes |
Member
|
included in docs PR for 1.15 at kubernetes/website#14671 |
7 tasks
4 tasks
Member
|
/area admission-control |
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
Feb 13, 2026
- `Port` field was introduced with Kubernetes v1.15 (kubernetes/kubernetes#74855) which didn't exit at the point - This webhook registration code was introduced with gardener-attic/gardener-extensions#218 - We were using `k8s.io/api@1.13.4` at this point in time: https://github.com/gardener-attic/gardener-extensions/blob/ef83a2368cdf11d11720bd198f5cba0161b48187/Gopkg.toml#L26-L28
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
Feb 13, 2026
- `Port` field was introduced with Kubernetes v1.15 (kubernetes/kubernetes#74855) which didn't exit at the point - This webhook registration code was introduced with gardener-attic/gardener-extensions#218 - We were using `k8s.io/api@1.13.4` at this point in time: https://github.com/gardener-attic/gardener-extensions/blob/ef83a2368cdf11d11720bd198f5cba0161b48187/Gopkg.toml#L26-L28
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
Feb 13, 2026
- `Port` field was introduced with Kubernetes v1.15 (kubernetes/kubernetes#74855) which didn't exit at the point - This webhook registration code was introduced with gardener-attic/gardener-extensions#218 - We were using `k8s.io/api@1.13.4` at this point in time: https://github.com/gardener-attic/gardener-extensions/blob/ef83a2368cdf11d11720bd198f5cba0161b48187/Gopkg.toml#L26-L28
gardener-prow bot
pushed a commit
to gardener/gardener
that referenced
this pull request
Feb 16, 2026
#14063) * [extensions] Set `servicePort` in `ServiceReference` for `ModeService` - `Port` field was introduced with Kubernetes v1.15 (kubernetes/kubernetes#74855) which didn't exit at the point - This webhook registration code was introduced with gardener-attic/gardener-extensions#218 - We were using `k8s.io/api@1.13.4` at this point in time: https://github.com/gardener-attic/gardener-extensions/blob/ef83a2368cdf11d11720bd198f5cba0161b48187/Gopkg.toml#L26-L28 * Adapt `admission-local`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work item for Admission Webhooks GA. To be consistent in the feature set of all webhooks and service references, the port configuration added to the rest of the features including kube-aggregator. All of these services share some level of code and it make sense to support this in all of them.
This however need to be documented for each service separately.
@liggitt @sttts @caesarxuchao