[extensions] Set servicePort in ServiceReference for ModeService#14063
Merged
gardener-prow[bot] merged 2 commits intogardener:masterfrom Feb 16, 2026
Merged
Conversation
Contributor
|
@rfranzke: GitHub didn't allow me to request PR reviews from the following users: databus23. Note that only gardener members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a074065 to
da7836e
Compare
- `Port` field was introduced with Kubernetes v1.15 (kubernetes/kubernetes#74855) which didn't exit at the point - This webhook registration code was introduced with gardener-attic/gardener-extensions#218 - We were using `k8s.io/api@1.13.4` at this point in time: https://github.com/gardener-attic/gardener-extensions/blob/ef83a2368cdf11d11720bd198f5cba0161b48187/Gopkg.toml#L26-L28
da7836e to
ac6ad65
Compare
Contributor
|
LGTM label has been added. DetailsGit tree hash: 0ae5fef54b881182bd77631a213a081676c0d2c9 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timuthy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest |
1 similar comment
Member
|
/retest |
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-registry-cache
that referenced
this pull request
Feb 27, 2026
This is a required adaptation to the breaking change in gardener/gardener#14063.
gardener-prow Bot
pushed a commit
to gardener/gardener-extension-registry-cache
that referenced
this pull request
Mar 4, 2026
* Bump github.com/gardener/gardener from 1.136.3 to 1.137.0 Bumps [github.com/gardener/gardener](https://github.com/gardener/gardener) from 1.136.3 to 1.137.0. - [Release notes](https://github.com/gardener/gardener/releases) - [Commits](https://github.com/gardener/gardener/commits) --- updated-dependencies: - dependency-name: github.com/gardener/gardener dependency-version: 1.137.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Run `gardener-api-types-submodule-import-path-migration.sh` See https://gist.github.com/LucaBernstein/a0a4bd39fb1232511ed0b65432fff653 * make format * make tidy * Update the `github.com/gardener/gardener/hack/tools/logcheck` module to the version of the `github.com/gardener/gardener` module * admission: Fix the `servicePort` This is a required adaptation to the breaking change in gardener/gardener#14063. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ismail Alidzhikov <9372594+ialidzhikov@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability
/kind bug
What this PR does / why we need it:
Portfield was introduced with Kubernetes v1.15 (Add Port configuration to ServiceReference of Admission webhooks, CRD Conversion Webhooks, AuditSink Webhooks and kube-aggregator kubernetes/kubernetes#74855) which didn't exit at the pointk8s.io/api@1.13.4at this point in time: https://github.com/gardener-attic/gardener-extensions/blob/ef83a2368cdf11d11720bd198f5cba0161b48187/Gopkg.toml#L26-L28Special notes for your reviewer:
/cc @databus23
Release note: